Fix Far1 "edit console output" empty output #1063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utput. This bug was introduced in rev. dd71baa (Don't run the command started by Shift-Enter from Far Manager via ConEmuC.exe.)
|
Hm, what conditions are when output is empty in the editor? What is purpose of the patch? Issue? |
|
I mean, macro Ctrl+O works for me perfectly. |
|
output is empty on any conditions, with any Far version. |
|
I don't see the problem: #688 (comment) |
Maximus5
reviewed
Mar 11, 2017
| @@ -2266,7 +2266,7 @@ int CShellProc::PrepareExecuteParms( | |||
| else | |||
| { | |||
| // хотят GUI прицепить к новой вкладке в ConEmu, или новую консоль из GUI | |||
| if (lbGuiApp && (NewConsoleFlags || bForceNewConsole)) | |||
| if ((bLongConsoleOutput) || (lbGuiApp && (NewConsoleFlags || bForceNewConsole))) | |||
There was a problem hiding this comment.
This is absolutely wrong. The condition checks for starting ChildGui in ConEmu tab, don't change it!
|
Well, I was wrong, Console output works with Far3, but at least with Far1 "Console output" is empty
|
michaellukashov
changed the title
Maximus5
added a commit
that referenced
this pull request
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description:
"Edit console output" shows empty output.
Steps to reproduce:
Run ConEmu with Far1,
Run any console program,
Pick "Plugin commands" -> "ConEmu" --> "Edit console output" command
Actual results
Far1 shows empty editor
Expected results
Far1 editor window with console output.