Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow fields with identical names. #15

Closed
MaxvdKolk opened this issue Apr 2, 2020 · 2 comments
Closed

Do not allow fields with identical names. #15

MaxvdKolk opened this issue Apr 2, 2020 · 2 comments
Assignees

Comments

@MaxvdKolk
Copy link
Owner

Writing data fields with identical identifiers (the name string) breaks the files. On Paraview 5.5 this crashes on loading. Add a check that errors whenever we try to insert another field with the same name?

@MaxvdKolk MaxvdKolk self-assigned this Apr 2, 2020
@MaxvdKolk
Copy link
Owner Author

The error message is now along the lines of "Array already contains field %s in fields %v". It seems that the xml name is not set explicitly, it comes through the name of the field in the struct. This is fine, but might limit the clarity of the error message? It might be nicer to append some additional info, where it goes wrong?

@MaxvdKolk
Copy link
Owner Author

The error message is now along the lines of "Array already contains field %s in fields %v". It seems that the xml name is not set explicitly, it comes through the name of the field in the struct. This is fine, but might limit the clarity of the error message? It might be nicer to append some additional info, where it goes wrong?

For now the behaviour seems fine. Directly after a call this error appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant