Theme names.

[bechampion]

Hi

Man i love your project , i started using it today , the only thing i took the liberty to modify is using them in the following format

export {PROFILE_NAME,PROFILE_SLUG}="One Light" && wget -O xt http://git.io/vs7UQ && chmod +x xt && ./xt && rm xt

So the name doesn't end like "Default".

I've also modified the themes.md page , so it reflects this , if you're ok with it i can create a PR

themes files modified:
themes.md.txt

dodge script that i used to do so:
transform.txt

thanks for your hard work on this.

[Mgldvd]

Hi, Thanks
About your solution there are 2 issues.
The first one is the terminal doesn't change color automatic, because you need to change the profile manually.
Someone already suggested do not overwrite the default profile. #26
The second is that does not work on linux mint because it creates an unnamed profile when you use space on the name.

# Wrong
export {PROFILE_NAME,PROFILE_SLUG}="One Light" && wget -O xt http://git.io/vs7UQ && chmod +x xt && ./xt && rm xt

# Correct
export {PROFILE_NAME,PROFILE_SLUG}="OneLight" && wget -O xt http://git.io/vs7UQ && chmod +x xt && ./xt && rm xt

I think the best approach is making this method optional.

[bechampion]

Hi !

Thank you!

I'm on Ubuntu 15 and when i don't pass the theme name , doesn't change the
profile automatically for me . I still have to go and choose it from the
menu.

Also one piece of constructive criticism , the whole wget ting and
executing makes me a bit uncomfortable , it'd be nice to have some script
to run after git cloning .

Thanks!

On Mon, Apr 11, 2016 at 12:54 AM, Mayccoll notifications@github.com wrote:

Hi, Thanks
About your solution there are 2 issues.
The first one is the terminal doesn't change color automatic, because you
need to change the profile manually.
Someone already suggested do not overwrite the default profile. #26
#26

The second is that does not work on linux mint because it creates an
unnamed profile when you use space on the name.

Wrongexport {PROFILE_NAME,PROFILE_SLUG}="One Light" && wget -O xt http://git.io/vs7UQ && chmod +x xt && ./xt && rm xt

Correctexport {PROFILE_NAME,PROFILE_SLUG}="OneLight" && wget -O xt http://git.io/vs7UQ && chmod +x xt && ./xt && rm xt

I think the best approach is making this method optional.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#38 (comment)

[jhonnymoreira]

Closed in PRs #45 and #46