tests: add a test for pkg-config files #8988

billatarm · 2024-03-25T13:55:24Z

tests: add a test for pkg-config files

Add a test that does some basic validation of the pkg-config files.

Example run:

./tests/scripts/all.sh test_cmake_as_package
******************************************************************
* test_cmake_as_package: build: cmake 'as-package' build
* Mon Apr 29 12:33:32 PM CDT 2024
******************************************************************
cmake .
make
Built against Mbed TLS 3.5.2
testing package config file: mbedtls ... passed
testing package config file: mbedx509 ... passed
testing package config file: mbedcrypto ... passed
make clean

Signed-off-by: Bill Roberts bill.roberts@arm.com

Description

Please write a few sentences describing the overall goals of the pull request's commits.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

changelog ~~provided, or~~ not required (Tests only, feature was previously added)
3.6 backport done ~~, or not required~~ [BACKPORT 3.6] tests: add a test for pkg-config files #9174
2.28 backport done ~~, or not required~~ [BACKPORT 2.28] tests: add a test for pkg-config files #9175
tests provided ~~, or not required~~

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

Multiple simple commits
- please structure your PR into a series of small commits, each of which does one thing
Avoid force-push
- please do not force-push to update your PR - just add new commit(s)
See our Guidelines for Contributors for more details about the review process.

billatarm · 2024-03-25T13:56:04Z

Ill do a back port for 2.28 once the reviewers are happy with this PR.

billatarm · 2024-03-25T13:57:25Z

@tom-cosgrove-arm and @gilles-peskine-arm

billatarm · 2024-03-25T13:58:01Z

Does the CI loop just run the all.sh script or is their anything I need to do to get the CI to pick this up?

tests/scripts/all.sh

gilles-peskine-arm · 2024-04-08T11:08:57Z

FYI the CI is still failing.

tests/pkgconfig.sh

tests/scripts/all.sh

tests/CMakeLists.txt

tests/Descriptions.txt

tests/scripts/all.sh

billatarm · 2024-04-30T18:14:44Z

FYI the CI is still failing.

The current CI is just showing orange, is it in some long queue or how do we kick that off?

tom-cosgrove-arm · 2024-04-30T21:07:12Z

The current CI is just showing orange, is it in some long queue or how do we kick that off?

I've kicked the CI - https://mbedtls.trustedfirmware.org/job/mbed-tls-pr-head/job/PR-8988-head/ - it won't run automatically on PRs from non-team members, sorry

gilles-peskine-arm · 2024-05-06T15:51:40Z

CI triggered

tests/scripts/pkgconfig.sh

Add a test that does some basic validation of the pkg-config files. Example run: ./tests/scripts/all.sh test_cmake_as_package ****************************************************************** * test_cmake_as_package: build: cmake 'as-package' build * Mon Apr 29 12:33:32 PM CDT 2024 ****************************************************************** cmake . make Built against Mbed TLS 3.5.2 testing package config file: mbedtls ... passed testing package config file: mbedx509 ... passed testing package config file: mbedcrypto ... passed make clean Signed-off-by: Bill Roberts <bill.roberts@arm.com>

paul-elliott-arm

LGTM

billatarm · 2024-05-23T14:09:41Z

LGTM

I'll backport this to 2.28 now

paul-elliott-arm · 2024-05-23T14:11:40Z

LGTM

I'll backport this to 2.28 now

And unfortunately 3.6, although that should be utterly trivial given the lack of differences there.

billatarm · 2024-05-23T16:21:56Z

LGTM

I'll backport this to 2.28 now

And unfortunately 3.6, although that should be utterly trivial given the lack of differences there.

3.6 backport is here: #9174

billatarm · 2024-05-23T17:14:40Z

LGTM

I'll backport this to 2.28 now

And unfortunately 3.6, although that should be utterly trivial given the lack of differences there.

3.6 backport is here: #9174

and 2.28: #9175

tom-cosgrove-arm

LGTM

gilles-peskine-arm · 2024-05-29T12:50:11Z

@tom-cosgrove-arm Did you mean to approve? You left a review comment that says “LGTM” but you didn't approve as defined by GitHub.

Add a test that does some basic validation of the pkg-config files. Note: this is a port of Mbed-TLS#8988 but is moved into a different test component so cmake shared infrastucture isn't needed. Example run: ./tests/scripts/all.sh test_cmake_shared ****************************************************************** * test_cmake_shared: build/test: cmake shared * Wed May 29 18:41:19 UTC 2024 ****************************************************************** cmake -DUSE_SHARED_MBEDTLS_LIBRARY=On . make <snip> testing package config file: mbedtls ... passed testing package config file: mbedx509 ... passed testing package config file: mbedcrypto ... passed make clean Signed-off-by: Bill Roberts <bill.roberts@arm.com>

tom-cosgrove-arm

LGTM

tom-cosgrove-arm · 2024-06-03T07:52:56Z

Did you mean to approve? You left a review comment that says “LGTM” but you didn't approve as defined by GitHub.

Yes, pretty sure I clicked the "Approve" radio button, but must have miss-clicked and not noticed.

Add a test that does some basic validation of the pkg-config files. Note: this is a port of Mbed-TLS#8988 but is moved into a different test component so cmake shared infrastucture isn't needed. Note this port of the patch detects the OS and skips so things like freebsd do not fail. Example run: ./tests/scripts/all.sh test_cmake_shared ****************************************************************** * test_cmake_shared: build/test: cmake shared * Wed May 29 18:41:19 UTC 2024 ****************************************************************** cmake -DUSE_SHARED_MBEDTLS_LIBRARY=On . make <snip> testing package config file: mbedtls ... passed testing package config file: mbedx509 ... passed testing package config file: mbedcrypto ... passed make clean Signed-off-by: Bill Roberts <bill.roberts@arm.com>

billatarm mentioned this pull request Mar 25, 2024

pkg-config: add initial pkg-config files #8691

Merged

3 tasks

paul-elliott-arm self-assigned this Mar 27, 2024

paul-elliott-arm requested changes Mar 27, 2024

View reviewed changes

tests/scripts/all.sh Outdated Show resolved Hide resolved

billatarm force-pushed the add-pc-files branch from eaad4b8 to aaa6dcf Compare March 27, 2024 15:40

gilles-peskine-arm added needs-work and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Apr 8, 2024

gilles-peskine-arm reviewed Apr 8, 2024

View reviewed changes

tests/pkgconfig.sh Outdated Show resolved Hide resolved

gilles-peskine-arm reviewed Apr 8, 2024

View reviewed changes

tests/pkgconfig.sh Outdated Show resolved Hide resolved

gilles-peskine-arm reviewed Apr 8, 2024

View reviewed changes

tests/pkgconfig.sh Outdated Show resolved Hide resolved

gilles-peskine-arm reviewed Apr 8, 2024

View reviewed changes

tests/scripts/all.sh Outdated Show resolved Hide resolved

billatarm force-pushed the add-pc-files branch 2 times, most recently from 0ff15a1 to a33fc7c Compare April 29, 2024 17:36

billatarm commented Apr 30, 2024

View reviewed changes

tests/CMakeLists.txt Outdated Show resolved Hide resolved

billatarm commented Apr 30, 2024

View reviewed changes

tests/Descriptions.txt Outdated Show resolved Hide resolved

billatarm commented Apr 30, 2024

View reviewed changes

tests/scripts/all.sh Outdated Show resolved Hide resolved

billatarm force-pushed the add-pc-files branch from a33fc7c to 3d696c2 Compare April 30, 2024 18:13

gilles-peskine-arm removed the needs-work label May 6, 2024

billatarm requested a review from paul-elliott-arm May 7, 2024 13:46

tom-cosgrove-arm reviewed May 7, 2024

View reviewed changes

tests/scripts/pkgconfig.sh Show resolved Hide resolved

tom-cosgrove-arm reviewed May 7, 2024

View reviewed changes

tests/scripts/pkgconfig.sh Outdated Show resolved Hide resolved

tom-cosgrove-arm reviewed May 7, 2024

View reviewed changes

tests/scripts/pkgconfig.sh Outdated Show resolved Hide resolved

billatarm force-pushed the add-pc-files branch from 1aeb5f9 to afe560c Compare May 7, 2024 14:23

paul-elliott-arm approved these changes May 23, 2024

View reviewed changes

paul-elliott-arm requested a review from tom-cosgrove-arm May 23, 2024 13:55

billatarm mentioned this pull request May 23, 2024

[BACKPORT 3.6] tests: add a test for pkg-config files #9174

Open

3 tasks

paul-elliott-arm removed the needs-ci Needs to pass CI tests label May 23, 2024

billatarm mentioned this pull request May 23, 2024

[BACKPORT 2.28] tests: add a test for pkg-config files #9175

Open

4 tasks

tom-cosgrove-arm reviewed May 25, 2024

View reviewed changes

tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports needs-backports Backports are missing or are pending review and approval. labels May 25, 2024

gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, and removed approved Design and code approved - may be waiting for CI or backports labels May 29, 2024

tom-cosgrove-arm approved these changes Jun 3, 2024

View reviewed changes

tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jun 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: add a test for pkg-config files #8988

tests: add a test for pkg-config files #8988

billatarm commented Mar 25, 2024 •

edited

billatarm commented Mar 25, 2024

billatarm commented Mar 25, 2024

billatarm commented Mar 25, 2024

gilles-peskine-arm commented Apr 8, 2024

billatarm commented Apr 30, 2024

tom-cosgrove-arm commented Apr 30, 2024

gilles-peskine-arm commented May 6, 2024

paul-elliott-arm left a comment

billatarm commented May 23, 2024

paul-elliott-arm commented May 23, 2024

billatarm commented May 23, 2024

billatarm commented May 23, 2024

tom-cosgrove-arm left a comment

gilles-peskine-arm commented May 29, 2024

tom-cosgrove-arm left a comment

tom-cosgrove-arm commented Jun 3, 2024

tests: add a test for pkg-config files #8988

Are you sure you want to change the base?

tests: add a test for pkg-config files #8988

Conversation

billatarm commented Mar 25, 2024 • edited

Description

PR checklist

Notes for the submitter

billatarm commented Mar 25, 2024

billatarm commented Mar 25, 2024

billatarm commented Mar 25, 2024

gilles-peskine-arm commented Apr 8, 2024

billatarm commented Apr 30, 2024

tom-cosgrove-arm commented Apr 30, 2024

gilles-peskine-arm commented May 6, 2024

paul-elliott-arm left a comment

Choose a reason for hiding this comment

billatarm commented May 23, 2024

paul-elliott-arm commented May 23, 2024

billatarm commented May 23, 2024

billatarm commented May 23, 2024

tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

gilles-peskine-arm commented May 29, 2024

tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

tom-cosgrove-arm commented Jun 3, 2024

billatarm commented Mar 25, 2024 •

edited