Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT 3.6] tests: add a test for pkg-config files #9174

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[BACKPORT 3.6] tests: add a test for pkg-config files #9174

merged 1 commit into from
Sep 11, 2024

Conversation

billatarm
Copy link
Contributor

@billatarm billatarm commented May 23, 2024 •
edited by paul-elliott-arm
Loading

Description

Trivial Backport of #8988

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog provided, or not required (Tests only, feature was previously added)
  • 3.6 backport done, or not required (This is the backport)
  • tests provided , or not required

@billatarm billatarm mentioned this pull request May 23, 2024
Merged
4 tasks
@paul-elliott-arm paul-elliott-arm self-assigned this May 23, 2024
@paul-elliott-arm paul-elliott-arm added enhancement needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review component-test Test framework and CI scripts size-xs Estimated task size: extra small (a few hours at most) priority-high High priority - will be reviewed soon labels May 23, 2024
paul-elliott-arm
paul-elliott-arm previously approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@paul-elliott-arm paul-elliott-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithful backport. LGTM

@tom-cosgrove-arm tom-cosgrove-arm removed needs-reviewer This PR needs someone to pick it up for review needs-ci Needs to pass CI tests labels May 25, 2024
tom-cosgrove-arm
tom-cosgrove-arm previously approved these changes May 25, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added the approved Design and code approved - may be waiting for CI or backports label May 25, 2024
@gilles-peskine-arm gilles-peskine-arm removed the needs-review Every commit must be reviewed by at least two team members, label May 29, 2024
@gilles-peskine-arm gilles-peskine-arm changed the title [BACKPORT 3.6] add pc test [BACKPORT 3.6] tests: add a test for pkg-config files Jun 11, 2024
@billatarm billatarm force-pushed the 3.6-add-pc-test branch 2 times, most recently from eaf96f2 to 2eb51e3 Compare September 4, 2024 20:48
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, and removed approved Design and code approved - may be waiting for CI or backports labels Sep 5, 2024
@gilles-peskine-arm gilles-peskine-arm added needs-work needs-ci Needs to pass CI tests and removed needs-review Every commit must be reviewed by at least two team members, labels Sep 5, 2024
@gilles-peskine-arm
Copy link
Contributor

Unfortunately the CI is unhappy.

@billatarm
Copy link
Contributor Author

Unfortunately the CI is unhappy.

Funny it worked everywhere else, let me see what I borked.

@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, and removed needs-work needs-ci Needs to pass CI tests labels Sep 9, 2024
@billatarm
tests: add a test for pkg-config files
3cc48e4 
Add a test that does some basic validation of the pkg-config files.

Example run:
./tests/scripts/all.sh test_cmake_as_package
<snip>
******************************************************************
* test_cmake_as_package: build: cmake 'as-package' build
* Wed Sep 11 16:22:09 UTC 2024
******************************************************************
cmake .
make
Built against Mbed TLS 3.6.1
testing package config file: mbedtls ... passed
testing package config file: mbedx509 ... passed
testing package config file: mbedcrypto ... passed
make clean

Signed-off-by: Bill Roberts <bill.roberts@arm.com>
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm
Copy link
Contributor

I've set the CI going on the latest commit

@tom-cosgrove-arm
Copy link
Contributor

CI is green

paul-elliott-arm
paul-elliott-arm approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@paul-elliott-arm paul-elliott-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paul-elliott-arm paul-elliott-arm added this pull request to the merge queue Sep 11, 2024
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit d3d586b Sep 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@paul-elliott-arm paul-elliott-arm paul-elliott-arm approved these changes

Assignees

@paul-elliott-arm paul-elliott-arm

Labels
component-test Test framework and CI scripts enhancement needs-review Every commit must be reviewed by at least two team members, priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Archived in project
Roadmap pull requests (new board)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@billatarm @gilles-peskine-arm @tom-cosgrove-arm @paul-elliott-arm