Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept MBIN_* naming convention in dot env files #45

Closed
melroy89 opened this issue Oct 15, 2023 · 4 comments
Closed

Accept MBIN_* naming convention in dot env files #45

melroy89 opened this issue Oct 15, 2023 · 4 comments
Labels
backend Backend related issues and pull requests enhancement New feature or request Stale Inactivity for too long

Comments

@melroy89
Copy link
Member

melroy89 commented Oct 15, 2023 •
edited
Loading

We should support for now both KBIN_* and MBIN_* in the dot env files configuration (eg. in files like: .env.example).

Then we should safely change the example files towards "MBIN" as well (used for new server owners). While also supporting existing servers that still running KBIN config files. Meaning we are backwards compatible for the foreseeing future.

This backwards compatibility is important if we want to keep easy migration from Kbin towards Mbin.
@melroy89 melroy89 added the enhancement New feature or request label Oct 15, 2023
@melroy89 melroy89 added this to the First release milestone Oct 15, 2023
@TheVillageGuy
Copy link
Contributor

TheVillageGuy commented Oct 16, 2023 •
edited
Loading

If it's not already the case, I'd suggest replacing all hard coded root paths with variables

@ghost ghost added the backend Backend related issues and pull requests label Oct 18, 2023
@melroy89 melroy89 modified the milestones: v1.1.0, v1.2.0 Nov 14, 2023
@melroy89 melroy89 removed this from the v1.2.0 milestone Nov 25, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

This issue is stale because it has been open 50 days with no activity. Remove stale label or comment or this will be closed in 6 days.

@github-actions github-actions bot added the Stale Inactivity for too long label Mar 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been stalled for 6 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 14, 2024
@BentiGorlich
Copy link
Member

@melroy89 want to reopen this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Backend related issues and pull requests enhancement New feature or request Stale Inactivity for too long
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@melroy89 @BentiGorlich @TheVillageGuy