Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16.4] Machine Infuser ONLY accepts Dimensional Shards from RFToolsBase, no other Dimensional Shards #34

Closed
kil0byt3 opened this issue Jan 5, 2021 · 5 comments

Comments

@kil0byt3
Copy link

kil0byt3 commented Jan 5, 2021

For instance, shards from Emendatus Enigmatica.

If I understand correctly how 1.16 works, can be solved with adding a tag requirement to the Machine Infuser, rather than only allowing a specific item (aka OreDict).

Pictures:

Emendatus Enigmatica item does not go in:
image

RFToolsBase item does:
image

Tags for both items:
image

@McJty
Copy link
Collaborator

McJty commented Jan 6, 2021

Hmm this is a bit intentional. I don't want anything else to be accepted here. Those other items (whatever they are) are not supposed to be dimensional shards

@merlerm
Copy link

merlerm commented Jan 6, 2021

What that mod is trying to do is add custom ores, so that it can have ores with the correct stone texture next to any kind of stone. That's the reason why it introduces its own dimensional shard ore and item, intended to be exactly the same as regular shards but self contained in the oregen mod, that's why it'd be nice to have them go in there. I don't see the harm in it?

@McJty
Copy link
Collaborator

McJty commented Jun 1, 2022

I'm going to implement this but on my own tag rftoolsbase:shards as this is a very specific item for RFTools

@McJty McJty closed this as completed Jun 1, 2022
@NielsPilgaard
Copy link

Sounds good 👍 will this be for 1.16.5 or just 1.18.2?

@McJty
Copy link
Collaborator

McJty commented Jun 1, 2022

Both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants