1.18.1: Serious bugs.

[MCcodeXX]

Issue description: Hi McJty. I've been a fan of the RFTools mods for several years and especially RFTools Control. It was my goto mod in 1.12.2 when it came to automation. Looks like there are some serious bugs in 1.18.1. I can not name node channels, only give names for the node itself. And it seems that there is a problem with the workbench, things often stay there and do not get to the processor. Or maybe there is a problem with "fetch items" Opcode or "get ingredients smart"? I also can not use storage scanner because the RFTools program i make does not «see» what is in storage even though I use the storage control module.

When you use a crafting station and want the finished product there, the result remains in the processor.

I hope you have time to set up a multi-step crafting program yourself and see if you can make it work in 1.18.1 like it did in 1.12.2.

Thanks for all you have done for the mincraft community over the years.

Steps to reproduce: Make recursive autocrafting program

Versions:

• Minecraft: 1.18.1
• Forge: 1.18.1 - 39.0.36
• McJtyLib: 1.18-6.0.7
• RFTools base: 1.18-3.0.3
• RFTools Control: 1.18-5.0.1
• RFTools Storage-1.18-3.0.4

Possibly incompatible mods and versions:

Relevant logs, if any:

[McJty]

The node bug has been found and will be fixed next version

[McJty]

Sorry, closed too quickly

[McJty]

Do you have a small example of the workbench going wrong?

[MCcodeXX]

Hi McJty. Thanks for the response. The problem with the workbench is well described here from "The Captain" for minecraft 1.16.5. The same issues are in 1.18.1:

#179

He talks about making a chest and only four planks are placed in the workbench. These planks stay there because it is not enough to make a chest.

[McJty]

BTW. I didn't forget about this. The node fix is now released but I still have to check the rest

[MCcodeXX]

Thanks for fixing this McJty!

[MCcodeXX]

So you did forget, didn't you? ;-)

[McJty]

Not really forget. Just no time

[jodamm]

Hi, I ran into the same problems, so I had a look at the code and made a fixed version for 1.16.
My fixes are more of the quick and dirty type, so I didn't made a pull request, but you could look in my fork what I have changed. There is also a compiled version for 1.16 available.
I fixed the following problems:

• Endresult of crafting was not put in the crafting station.
  For the inventory slots of the crafting stations it is not allowed to put items in from automation, so I gave them the property to allow it.

• Autocrafting is not counting correct.
  The function "combineIngredients" was commented out, and the list is now of the type ingredient. To count them I create a list of the type Itemstack and after counting, convert it back to a list of the type ingredient.

• Autocrafting is not working with storage scanner.
  The function to get the inventory handler was some time ago changed to a lambda expression, but with the storage scanner the inventory is null and the whole function is not executed, but returns a 0. I changed the lambda expression to only get the handler and not include the whole function.

And many thanks for the mods, it makes a lot of fun to automate with the RFTools.