Skip to content
This repository has been archived by the owner on Nov 21, 2020. It is now read-only.

Progress #5

Closed
24 of 26 tasks
McSinyx opened this issue Dec 30, 2019 · 14 comments
Closed
24 of 26 tasks

Progress #5

McSinyx opened this issue Dec 30, 2019 · 14 comments
Assignees
Milestone

Comments

@McSinyx
Copy link
Owner

McSinyx commented Dec 30, 2019

This issue is dedicated to track the current progress on wrapping alure classes.

Classes we've started working on:

  • DeviceManager
  • Device
  • Context
  • Listener
  • Buffer
  • Source
  • SourceGroup
  • AuxiliaryEffectSlot
  • Effect
  • Decoder
  • DecoderFactory
  • FileIOFactory
  • MessageHandler

Classes completely implemented:

  • DeviceManager
  • Device
  • Context
  • Listener
  • Buffer
  • Source
  • SourceGroup
  • AuxiliaryEffectSlot
  • Effect
  • Decoder
  • DecoderFactory
  • FileIOFactory
  • MessageHandler

Please update this checklist as you push changes to master.

@McSinyx McSinyx added this to the 0.1 milestone Dec 30, 2019
@McSinyx McSinyx pinned this issue Dec 30, 2019
@McSinyx
Copy link
Owner Author

McSinyx commented Jan 4, 2020

kcat/alure#17 gives a good overview of what each class' responsibility if it is not clear in alure2.h

@McSinyx
Copy link
Owner Author

McSinyx commented Jan 9, 2020

Decoder, DecoderFactory, FileIOFactory and MessageHandler are interfaces, which may be wrapped using cpdef as shown in CEP 529.

@Huy-Ngo
Copy link
Collaborator

Huy-Ngo commented Jan 18, 2020

@9a24f0 Which class are you taking so I won't do your work?

@9a24f0
Copy link
Collaborator

9a24f0 commented Jan 19, 2020

@Huy-Ngo the lower one, i.e Effect

@McSinyx
Copy link
Owner Author

McSinyx commented Jan 24, 2020

Gental ping: how are your progress so far? BTW there's a new example play3d.cpp from alure that one of you might wanna trynna port to Python to get more used with palace's usage. example/play.py might be a good start.

After 19227e5, one may run linting tests using tox to make sure (sort of) the formatting is acceptable. Unit tests need to be written but that belongs to another issue.

BTW the check list is supposed to track master, only tick when your commit is pushed there.

@Huy-Ngo
Copy link
Collaborator

Huy-Ngo commented Jan 25, 2020

BTW the check list is supposed to track master, only tick when your commit is pushed there.

For both checklists?

@McSinyx
Copy link
Owner Author

McSinyx commented Jan 25, 2020

Yep: if one wanna work on something per can always leave a comment here. The idea is that for temporary tasks (on the go) we can always remember what's happening, but for stuff we halt in the middle, the check list is there to remind what is missing.

Happy New Year BTW.

@McSinyx
Copy link
Owner Author

McSinyx commented Feb 6, 2020

@Huy-Ngo: Since you're done with the effect slot implementation, do you want to port the alure-play3d.cpp example to Python? example/palace-play.py can be used as a based.

@9a24f0: What's up with the effects? Did you caught the carolina viri thingie?

@Huy-Ngo
Copy link
Collaborator

Huy-Ngo commented Feb 7, 2020

That's ok to me, but I'm probably not going to do it this week.

@Huy-Ngo
Copy link
Collaborator

Huy-Ngo commented Feb 9, 2020

OK I will start on alure-play3d.cpp on branch eg-p3d

@McSinyx
Copy link
Owner Author

McSinyx commented Feb 9, 2020

My dyslexium read that as peg-3d 😕

@Huy-Ngo
Copy link
Collaborator

Huy-Ngo commented Feb 10, 2020

@McSinyx Why does palace-play.py look so different from alure-play.cpp?

@McSinyx
Copy link
Owner Author

McSinyx commented Feb 10, 2020

That's the point of palace: to simplify the API. Read carefully and you'll realize they do the exact same thing.

@McSinyx
Copy link
Owner Author

McSinyx commented Mar 2, 2020

Closing this in favor of #24, #44 and #45.

@McSinyx McSinyx closed this as completed Mar 2, 2020
@McSinyx McSinyx unpinned this issue Mar 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants