Skip to content
This repository has been archived by the owner on Nov 21, 2020. It is now read-only.

Finish Context and Source #44

Closed
McSinyx opened this issue Mar 2, 2020 · 7 comments · Fixed by #65
Closed

Finish Context and Source #44

McSinyx opened this issue Mar 2, 2020 · 7 comments · Fixed by #65
Assignees
@Huy-Ngo
Milestone
0.1

Comments

@McSinyx
Copy link
Owner

McSinyx commented Mar 2, 2020

Try to do as many TODO as you are able to do, gradually.
@McSinyx McSinyx added this to the 0.1 milestone Mar 2, 2020
@McSinyx McSinyx mentioned this issue Mar 2, 2020
Closed
26 tasks
@Huy-Ngo
Copy link
Collaborator

Huy-Ngo commented Mar 5, 2020

Are these lines included in this issue?

palace/src/palace.pyx

Lines 149 to 150 in 308671b

# TODO: current_context_thread
# TODO: use_context_thread

@McSinyx
Copy link
Owner Author

McSinyx commented Mar 5, 2020

Yep, and please implement them as part of {use,current}_context using optional parameters (thread or something like that).

@Huy-Ngo
Copy link
Collaborator

Huy-Ngo commented Mar 5, 2020 •
edited
Loading

I should write thread: Optional[bool] in the function arguments instead of thread=False right? Or is it thread: bool=False?

@McSinyx
Copy link
Owner Author

McSinyx commented Mar 5, 2020

thread: bool = False, Optional is a really misleading name IMHO.

@McSinyx McSinyx linked a pull request Mar 19, 2020 that will close this issue
Adding context functionalities #53
Merged
@McSinyx McSinyx removed a link to a pull request Mar 19, 2020
Adding context functionalities #53
Merged
@McSinyx
Copy link
Owner Author

McSinyx commented Mar 21, 2020

Just a friendly reminder that this isn't finished.

This was referenced Mar 21, 2020
Closed
Closed
McSinyx referenced this issue Mar 23, 2020
@Huy-Ngo
Enable threading in use_context and current_context
266cca6
@McSinyx McSinyx self-assigned this Mar 30, 2020
@McSinyx
Copy link
Owner Author

McSinyx commented Mar 30, 2020 •
edited
Loading

I'm finishing the source it make effects work. nvm go on we already got aux send defined.

@McSinyx McSinyx removed their assignment Mar 30, 2020
@McSinyx
Copy link
Owner Author

McSinyx commented Mar 31, 2020

Gentle ping, @Huy-Ngo

@Huy-Ngo Huy-Ngo mentioned this issue Apr 1, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Huy-Ngo Huy-Ngo

Labels
None yet
Projects
None yet
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Finishing the Source class McSinyx/palace
2 participants
@McSinyx @Huy-Ngo