Skip to content
This repository has been archived by the owner on Nov 21, 2020. It is now read-only.

Implement Effect and relevant methods #24

Closed
Huy-Ngo opened this issue Feb 4, 2020 · 5 comments · Fixed by #54 or #58
Closed

Implement Effect and relevant methods #24

Huy-Ngo opened this issue Feb 4, 2020 · 5 comments · Fixed by #54 or #58
Assignees
@9a24f0
Milestone
0.1

Comments

@Huy-Ngo
Copy link
Collaborator

Huy-Ngo commented Feb 4, 2020

Since this method uses unimplemented class Effect, I will leave this until @9a24f0 finish it.
@McSinyx McSinyx added this to the 0.1 milestone Feb 5, 2020
@McSinyx
Copy link
Owner

McSinyx commented Feb 21, 2020

Gentle ping: what's up @9a24f0? Is there anything we can do to help you move forward (with this, with life, with your anime addiction)?

@McSinyx
Copy link
Owner

McSinyx commented Feb 24, 2020

Gentle pong: @9a24f0, you have to communicate. There's no way we can move this forward with you not saying anything. If there is any trouble(s), you have to state them.

@McSinyx McSinyx changed the title [AuxiliaryEffectSlot] Implement the method apply_effect Implement Effect and relevant methods Mar 2, 2020
@McSinyx McSinyx mentioned this issue Mar 2, 2020
Closed
26 tasks
@McSinyx
Copy link
Owner

McSinyx commented Mar 15, 2020

@9a24f0: You may use data classes as user interface for reverb and chorus properties if you want to, although that'll require Python 3.7+.

@McSinyx McSinyx linked a pull request Mar 21, 2020 that will close this issue
Merging 'new-eff' to 'master' #54
Merged
@McSinyx
Copy link
Owner

McSinyx commented Mar 21, 2020

Note that AuxiliaryEffectSlot.apply_effect is not yet implemented in GH-54.

@McSinyx McSinyx reopened this Mar 23, 2020
@McSinyx
Copy link
Owner

McSinyx commented Mar 23, 2020

See d5cf95c.

@McSinyx McSinyx linked a pull request Mar 23, 2020 that will close this issue
Merging new-eff to master and finished relevant methods #58
Merged
@McSinyx McSinyx mentioned this issue Mar 29, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@9a24f0 9a24f0

Labels
None yet
Projects
None yet
Milestone
0.1
3 participants
@McSinyx @Huy-Ngo @9a24f0