Add anal_warnings_cxx.m4

Meai1 · May 11, 2012 · 3a6659d · 3a6659d
1 parent 082bfb5
commit 3a6659d
Show file tree

Hide file tree

Showing 4 changed files with 122 additions and 0 deletions.
diff --git a/configure.ac b/configure.ac
@@ -16,6 +16,8 @@ AC_CONFIG_MACRO_DIR([m4])
 AC_PROG_CXX
 AC_PROG_CC
 
+ANAL_WARNINGS_CXX
+
 # Checks for libraries.
 GTEST_LIB_CHECK
 PKG_CHECK_MODULES([PO6], [libpo6 >= 0.2])

diff --git a/m4/anal_warnings_cxx.m4 b/m4/anal_warnings_cxx.m4
@@ -0,0 +1,118 @@
+# Copyright (c) 2012, Robert Escriva
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+#     * Redistributions of source code must retain the above copyright notice,
+#       this list of conditions and the following disclaimer.
+#     * Redistributions in binary form must reproduce the above copyright
+#       notice, this list of conditions and the following disclaimer in the
+#       documentation and/or other materials provided with the distribution.
+#     * Neither the name of this project nor the names of its contributors may
+#       be used to endorse or promote products derived from this software
+#       without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE
+# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#
+# This macro enables many compiler warnings for C++ that generally catch bugs in
+# code.  It offers the "--enable-wanal-cxxflags" option which defaults to "no".
+
+AC_DEFUN([ANAL_WARNINGS_CXX],
+    [WANAL_CXXFLAGS=""
+    AC_ARG_ENABLE([wanal-cxxflags], [AS_HELP_STRING([--enable-wanal-cxxflags],
+              [enable many warnings @<:@default: no@:>@])],
+              [wanal_cxxflags=${enableval}], [wanal_cxxflags=no])
+    if test x"${wanal_cxxflags}" = xyes; then
+        AX_CXX_CHECK_FLAG([-pedantic],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -pedantic"],)
+        AX_CXX_CHECK_FLAG([-Wall],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wall"],)
+        AX_CXX_CHECK_FLAG([-Wextra],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wextra"],)
+        AX_CXX_CHECK_FLAG([-Wabi],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wabi"],)
+        AX_CXX_CHECK_FLAG([-Waddress],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Waddress"],)
+        #AX_CXX_CHECK_FLAG([-Waggregate-return],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Waggregate-return"],)
+        AX_CXX_CHECK_FLAG([-Warray-bounds],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Warray-bounds"],)
+        AX_CXX_CHECK_FLAG([-Wc++0x-compat],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wc++0x-compat"],)
+        AX_CXX_CHECK_FLAG([-Wcast-align],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wcast-align"],)
+        AX_CXX_CHECK_FLAG([-Wcast-qual],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wcast-qual"],)
+        AX_CXX_CHECK_FLAG([-Wchar-subscripts],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wchar-subscripts"],)
+        AX_CXX_CHECK_FLAG([-Wclobbered],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wclobbered"],)
+        AX_CXX_CHECK_FLAG([-Wcomment],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wcomment"],)
+        AX_CXX_CHECK_FLAG([-Wconversion],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wconversion"],)
+        AX_CXX_CHECK_FLAG([-Wctor-dtor-privacy],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wctor-dtor-privacy"],)
+        AX_CXX_CHECK_FLAG([-Wdisabled-optimization],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wdisabled-optimization"],)
+        AX_CXX_CHECK_FLAG([-Weffc++],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Weffc++"],)
+        AX_CXX_CHECK_FLAG([-Wempty-body],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wempty-body"],)
+        AX_CXX_CHECK_FLAG([-Wenum-compare],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wenum-compare"],)
+        AX_CXX_CHECK_FLAG([-Wfloat-equal],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wfloat-equal"],)
+        AX_CXX_CHECK_FLAG([-Wformat],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wformat"],)
+        AX_CXX_CHECK_FLAG([-Wformat=2],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wformat=2"],)
+        AX_CXX_CHECK_FLAG([-Wformat-nonliteral],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wformat-nonliteral"],)
+        AX_CXX_CHECK_FLAG([-Wformat-security],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wformat-security"],)
+        AX_CXX_CHECK_FLAG([-Wformat-y2k],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wformat-y2k"],)
+        AX_CXX_CHECK_FLAG([-Wframe-larger-than=8192],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wframe-larger-than=8192"],)
+        AX_CXX_CHECK_FLAG([-Wignored-qualifiers],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wignored-qualifiers"],)
+        AX_CXX_CHECK_FLAG([-Wimplicit],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wimplicit"],)
+        AX_CXX_CHECK_FLAG([-Winit-self],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Winit-self"],)
+        AX_CXX_CHECK_FLAG([-Winline],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Winline"],)
+        AX_CXX_CHECK_FLAG([-Wlarger-than=4096],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wlarger-than=4096"],)
+        AX_CXX_CHECK_FLAG([-Wlogical-op],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wlogical-op"],)
+        AX_CXX_CHECK_FLAG([-Wmain],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wmain"],)
+        AX_CXX_CHECK_FLAG([-Wmissing-braces],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wmissing-braces"],)
+        AX_CXX_CHECK_FLAG([-Wmissing-declarations],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wmissing-declarations"],)
+        AX_CXX_CHECK_FLAG([-Wmissing-field-initializers],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wmissing-field-initializers"],)
+        AX_CXX_CHECK_FLAG([-Wmissing-format-attribute],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wmissing-format-attribute"],)
+        AX_CXX_CHECK_FLAG([-Wmissing-include-dirs],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wmissing-include-dirs"],)
+        AX_CXX_CHECK_FLAG([-Wmissing-noreturn],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wmissing-noreturn"],)
+        AX_CXX_CHECK_FLAG([-Wnon-virtual-dtor],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wnon-virtual-dtor"],)
+        AX_CXX_CHECK_FLAG([-Wold-style-cast],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wold-style-cast"],)
+        AX_CXX_CHECK_FLAG([-Woverlength-strings],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Woverlength-strings"],)
+        AX_CXX_CHECK_FLAG([-Woverloaded-virtual],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Woverloaded-virtual"],)
+        AX_CXX_CHECK_FLAG([-Wpacked],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wpacked"],)
+        AX_CXX_CHECK_FLAG([-Wpacked-bitfield-compat],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wpacked-bitfield-compat"],)
+        AX_CXX_CHECK_FLAG([-Wpadded],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wpadded"],)
+        AX_CXX_CHECK_FLAG([-Wparentheses],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wparentheses"],)
+        AX_CXX_CHECK_FLAG([-Wpointer-arith],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wpointer-arith"],)
+        AX_CXX_CHECK_FLAG([-Wredundant-decls],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wredundant-decls"],)
+        AX_CXX_CHECK_FLAG([-Wreorder],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wreorder"],)
+        AX_CXX_CHECK_FLAG([-Wreturn-type],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wreturn-type"],)
+        AX_CXX_CHECK_FLAG([-Wsequence-point],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wsequence-point"],)
+        AX_CXX_CHECK_FLAG([-Wshadow],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wshadow"],)
+        AX_CXX_CHECK_FLAG([-Wsign-compare],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wsign-compare"],)
+        AX_CXX_CHECK_FLAG([-Wsign-conversion],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wsign-conversion"],)
+        AX_CXX_CHECK_FLAG([-Wsign-promo],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wsign-promo"],)
+        AX_CXX_CHECK_FLAG([-Wstack-protector],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wstack-protector"],)
+        AX_CXX_CHECK_FLAG([-Wstrict-aliasing],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wstrict-aliasing"],)
+        AX_CXX_CHECK_FLAG([-Wstrict-aliasing=3],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wstrict-aliasing=3"],)
+        AX_CXX_CHECK_FLAG([-Wstrict-null-sentinel],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wstrict-null-sentinel"],)
+        AX_CXX_CHECK_FLAG([-Wstrict-overflow],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wstrict-overflow"],)
+        AX_CXX_CHECK_FLAG([-Wstrict-overflow=4],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wstrict-overflow=4"],)
+        AX_CXX_CHECK_FLAG([-Wswitch],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wswitch"],)
+        AX_CXX_CHECK_FLAG([-Wswitch-default],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wswitch-default"],)
+        AX_CXX_CHECK_FLAG([-Wswitch-enum],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wswitch-enum"],)
+        AX_CXX_CHECK_FLAG([-Wtrigraphs],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wtrigraphs"],)
+        AX_CXX_CHECK_FLAG([-Wtype-limits],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wtype-limits"],)
+        AX_CXX_CHECK_FLAG([-Wundef],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wundef"],)
+        AX_CXX_CHECK_FLAG([-Wuninitialized],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wuninitialized"],)
+        #AX_CXX_CHECK_FLAG([-Wunreachable-code],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wunreachable-code"],)
+        AX_CXX_CHECK_FLAG([-Wunsafe-loop-optimizations],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wunsafe-loop-optimizations"],)
+        AX_CXX_CHECK_FLAG([-Wunused],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wunused"],)
+        AX_CXX_CHECK_FLAG([-Wunused-function],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wunused-function"],)
+        AX_CXX_CHECK_FLAG([-Wunused-label],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wunused-label"],)
+        AX_CXX_CHECK_FLAG([-Wunused-parameter],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wunused-parameter"],)
+        AX_CXX_CHECK_FLAG([-Wunused-value],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wunused-value"],)
+        AX_CXX_CHECK_FLAG([-Wunused-variable],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wunused-variable"],)
+        AX_CXX_CHECK_FLAG([-Wvolatile-register-var],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wvolatile-register-var"],)
+        AX_CXX_CHECK_FLAG([-Wwrite-strings],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wwrite-strings"],)
+        AX_CXX_CHECK_FLAG([-Wno-long-long],,,[WANAL_CXXFLAGS="${WANAL_CXXFLAGS} -Wno-long-long"],)
+    fi
+    AC_SUBST([WANAL_CXXFLAGS], [${WANAL_CXXFLAGS}])
+])
diff --git a/src/Makefile.am b/src/Makefile.am
@@ -1,4 +1,5 @@
 AM_CPPFLAGS = -I$(abs_top_srcdir)/include $(PO6_CFLAGS)
+AM_CXXFLAGS = $(WANAL_CXXFLAGS)
 
 lib_LTLIBRARIES = libe.la
 

diff --git a/test/Makefile.am b/test/Makefile.am
@@ -1,5 +1,6 @@
 if HAVE_GTEST
 AM_CPPFLAGS = -I$(abs_top_srcdir)/include $(PO6_CFLAGS) $(GTEST_CPPFLAGS)
+AM_CXXFLAGS = $(WANAL_CXXFLAGS)
 AM_LDFLAGS = $(GTEST_LDFLAGS)
 
 TESTS = $(check_PROGRAMS)