Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify list of engine.io transports through the SIOSocket client. #38

Merged
merged 1 commit into from
Feb 17, 2015

Conversation

brandonramirez
Copy link
Contributor

Resolves #35

… client. Over-loaded to preserve API backward-compatibility and used default that is contained within the socket.io-client.
@brandonramirez
Copy link
Contributor Author

Any feedback on this change? I don't like maintaining my own fork, so I hope this can be included in the mainline repository and part of the next release.

@gtomitsuka
Copy link

+1. Helps a lot.

@agconti
Copy link

agconti commented Feb 6, 2015

+1. We found this ourselves. Its necessary for sockets to properly connect to servers running more than one dyno.

@glemmaPaul
Copy link

+1. This also resolves a lot of problems with 2 dyno's on Heroku. I have to force the socket.io client to use websocket. Please merge this in.

@andrew-frank
Copy link

Amazing, thanks guys! To solve the problem of 2 dyno's on Heroku, I had to use only "websocket" transports. Also in socket.io.js.h there was one argument missing (NSArray *transports) and I couldn't compile because of it

static NSString *socket_io_js_constructor(NSString *hostURL, BOOL reconnection, NSInteger attemptLimit, NSTimeInterval reconnectionDelay, NSTimeInterval reconnectionDelayMax, NSTimeInterval timeout, NSArray *transports) { 
    ... 
}

@glemmaPaul
Copy link

Exactly, the transports need to be on websockets to not let it fail connecting. The cause of it can be because of the long polling functionality on the beginning. The router fails to keep it on one web dyno.

On Saturday, Feb 14, 2015 at 12:04 PM, frandrzej notifications@github.com, wrote:

Amazing, thanks guys! To solve the problem of 2 dyno's on Heroku, I had to use only "websocket" transports. Also in socket.io.js.h there was one argument missing (NSArray *transports) and I couldn't compile because of it

static NSString *socket_io_js_constructor(NSString *hostURL, BOOL reconnection, NSInteger attemptLimit, NSTimeInterval reconnectionDelay, NSTimeInterval reconnectionDelayMax, NSTimeInterval timeout, NSArray *transports) {
...
}


Reply to this email directly or view it on GitHub.

@andrew-frank andrew-frank mentioned this pull request Feb 16, 2015
pcperini added a commit that referenced this pull request Feb 17, 2015
Ability to specify list of engine.io transports through the SIOSocket client.
@pcperini pcperini merged commit 6d9a315 into MegaBits:master Feb 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify transports
6 participants