Squadron disband damage is not applied correctly

[neoancient]

Fighters that are destroyed while they are part of squadrons do not have any damage applied. Those that survive have capital scale damage applied as standard scale regardless of whether the aero sanity option is in use. While this does not affect the game in MegaMek, it does affect post-battle resolution in MekHQ and any exported entity list file.

[mkerensky]

This needs to be reopened for version 0.45.4. I'll take care of it.

[sixlettervariables]

@mkerensky in MM or MHQ?

[mkerensky]

This is in MM. Aero.doDisbandDamage() is where the issue is.

[HammerGS]

Per mkerensky's request.

[mkerensky]

I fixed the issues in doDisbandDamage(). The check for Aero Sanity was incorrectly multiplying the disband damage by 10 with AS on - it only needs to do this when the AS option is off.
Also, the actual damage application process was inflicting the total damage for each hit, when it should have been breaking the total damage into 5 point clusters in inflicting one of those for each hit.

Now there's still a problem where the armor after disband damage is being reconverted into Capital Scale as MHQ does battle resolution, so you have to replace ~90% of your armor at standard scale after every battle. Not sure yet whether that's an MM or MHQ problem.

[sixlettervariables]

Fixed in #1273.