Multi target shooting #1329
Merged
Multi target shooting #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixlettervariables
approved these changes
Apr 19, 2019
| for(Targetable target : getTargetableEnemyEntities(weapon.getEntity(), owner.getGame(), owner.getFireControlState())) { | ||
| final int ownerID = (target instanceof Entity) ? ((Entity) target).getOwnerId() : -1; | ||
| if(owner.getHonorUtil().isEnemyBroken(target.getTargetId(), ownerID, owner.getBehaviorSettings().isForcedWithdrawal())) { | ||
| owner.log(getClass(), "MultiTargetFireControl.getBestShot", LogLevel.INFO, target.getDisplayName() + " is broken - ignoring"); |
There was a problem hiding this comment.
Should this be WARN or DEBUG instead of Info?
There was a problem hiding this comment.
It's "INFO" in the other places where isEnemyBroken is invoked, so I followed that pattern. I could be convinced to call it DEBUG as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes allows the bot to consider shooting at multiple targets, as long as the unit doing the shooting isn't subject to secondary target penalties (incorporating secondary target penalties is a lot more difficult).
This affects large spacecraft, multi-crewed vehicles (when the appropriate tacops rule is turned on), units with the MultiTrac quirk and units with the MultiTasker SPA, greatly increasing their effectiveness on the field.
A side effect is that the bot will also incorporate the "combat computer" quirk into its firing plan for those units.