Suite Version Tracking: Adding Full Versioning and Version Protection in MegaMek #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2021
|
This pull request fixes 2 alerts when merging df4c5cf into 2c9538b - view on LGTM.com fixed alerts:
|
NickAragua
approved these changes
Oct 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves Version to be tracked based on a constant across the suite, and expands incorrect version protection. This will prevent any issues relating to loading a save file from a previous version, provided the file does serialize first (which would require changes to MegaMek file I/O... but would fail anyway) and isn't from the same dev snapshot. It also prevents any issues from joining a server of the wrong version. It does not handle within a snapshot, which may or may not work based on the current changes to the Game class.
Once this is merged I'll update the build document on the wiki, as it reduces the number of version text changes required from 6 to 4.