Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DRAFT) Detachable Unit Detail Removal #3627

Conversation

Windchild292
Copy link
Member

This invalidates #3223, #3272, #3309, #3372, #3579, #3616

@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #3627 (6ab4fba) into master (4085fa8) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #3627      +/-   ##
============================================
+ Coverage     23.75%   23.76%   +0.01%     
  Complexity     4878     4878              
============================================
  Files          2199     2198       -1     
  Lines        242627   242490     -137     
  Branches      45454    45448       -6     
============================================
- Hits          57643    57637       -6     
+ Misses       183501   183370     -131     
  Partials       1483     1483              
Impacted Files Coverage Δ
...c/megamek/client/ui/dialogs/UnitDisplayDialog.java 0.00% <0.00%> (ø)
megamek/src/megamek/client/ui/swing/ClientGUI.java 0.00% <0.00%> (ø)
...src/megamek/client/ui/swing/DeploymentDisplay.java 0.00% <0.00%> (ø)
...mek/src/megamek/client/ui/swing/FiringDisplay.java 0.00% <0.00%> (ø)
...ek/src/megamek/client/ui/swing/GUIPreferences.java 33.49% <ø> (+0.48%) ⬆️
megamek/src/megamek/client/ui/swing/MapMenu.java 0.00% <0.00%> (ø)
...k/src/megamek/client/ui/swing/MovementDisplay.java 0.00% <0.00%> (ø)
...k/src/megamek/client/ui/swing/PhysicalDisplay.java 0.00% <0.00%> (ø)
...megamek/client/ui/swing/PointblankShotDisplay.java 0.00% <0.00%> (ø)
...k/src/megamek/client/ui/swing/PrephaseDisplay.java 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4085fa8...6ab4fba. Read the comment docs.

@Windchild292
Copy link
Member Author

Subsumed by #3629

@Windchild292 Windchild292 deleted the dev_Windchild_DockableUnitDetailRemoval branch May 9, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment