-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detachable Unit Display Removal #3629
Detachable Unit Display Removal #3629
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3629 +/- ##
=========================================
Coverage 23.75% 23.76%
Complexity 4878 4878
=========================================
Files 2199 2198 -1
Lines 242627 242540 -87
Branches 45454 45455 +1
=========================================
- Hits 57643 57639 -4
+ Misses 183501 183418 -83
Partials 1483 1483
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one, we'll definitely need people to bang on before we hit the release.
I completely concur, and it is already part of the testing branch builds from last night. |
This tears out the Detachable Unit Display and replaces it with (largely) the original code.
It replaces #3627, which kept having odd phase issues. By invalidation, this closes #3223, closes #3272, closes #3309, closes #3372, closes #3579, and closes #3616.
I will be following this up with an AbstractDialog rework (some baseline changes included) and Skin Editor dialog update immediately after 0.49.8.