Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detachable Unit Display Removal #3629

Merged

Conversation

Windchild292
Copy link
Contributor

This tears out the Detachable Unit Display and replaces it with (largely) the original code.
It replaces #3627, which kept having odd phase issues. By invalidation, this closes #3223, closes #3272, closes #3309, closes #3372, closes #3579, and closes #3616.

I will be following this up with an AbstractDialog rework (some baseline changes included) and Skin Editor dialog update immediately after 0.49.8.

@Windchild292 Windchild292 added GUI User Interface Blocker labels May 9, 2022
@Windchild292 Windchild292 self-assigned this May 9, 2022
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #3629 (2a5f604) into master (4085fa8) will increase coverage by 0.00%.
The diff coverage is 0.64%.

@@            Coverage Diff            @@
##             master    #3629   +/-   ##
=========================================
  Coverage     23.75%   23.76%           
  Complexity     4878     4878           
=========================================
  Files          2199     2198    -1     
  Lines        242627   242540   -87     
  Branches      45454    45455    +1     
=========================================
- Hits          57643    57639    -4     
+ Misses       183501   183418   -83     
  Partials       1483     1483           
Impacted Files Coverage Δ
...c/megamek/client/ui/dialogs/UnitDisplayDialog.java 0.00% <0.00%> (ø)
megamek/src/megamek/client/ui/swing/ClientGUI.java 0.00% <0.00%> (ø)
...src/megamek/client/ui/swing/DeploymentDisplay.java 0.00% <0.00%> (ø)
...mek/src/megamek/client/ui/swing/FiringDisplay.java 0.00% <0.00%> (ø)
megamek/src/megamek/client/ui/swing/MapMenu.java 0.00% <0.00%> (ø)
...k/src/megamek/client/ui/swing/MovementDisplay.java 0.00% <0.00%> (ø)
...k/src/megamek/client/ui/swing/PhysicalDisplay.java 0.00% <0.00%> (ø)
...megamek/client/ui/swing/PointblankShotDisplay.java 0.00% <0.00%> (ø)
...k/src/megamek/client/ui/swing/PrephaseDisplay.java 0.00% <0.00%> (ø)
...mek/src/megamek/client/ui/swing/ReportDisplay.java 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4085fa8...2a5f604. Read the comment docs.

Copy link
Member

@NickAragua NickAragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one, we'll definitely need people to bang on before we hit the release.

@Windchild292
Copy link
Contributor Author

I completely concur, and it is already part of the testing branch builds from last night.

@Windchild292 Windchild292 merged commit 807a028 into MegaMek:master May 11, 2022
@Windchild292 Windchild292 deleted the dev_Windchild_DockableTearout branch May 11, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment