Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGTM: Fixing the vast majority of open issues #1052

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

Windchild292
Copy link
Member

@Windchild292 Windchild292 commented Feb 28, 2022

This fixes all but four of the current LGTM issues for MML, including multiple resource leaks.

Once this is merged I'll fix the final four issues.

To Review:
Whitespace differences off, as I also fixed some whitespace problems.

@Windchild292 Windchild292 self-assigned this Feb 28, 2022
@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2022

This pull request fixes 12 alerts when merging 9b8f76c into 4849775 - view on LGTM.com

fixed alerts:

  • 7 for Dereferenced variable may be null
  • 3 for Potential input resource leak
  • 2 for Boxed variable is never null

@lgtm-com
Copy link

lgtm-com bot commented Mar 1, 2022

This pull request fixes 26 alerts when merging f3f7c02 into 4849775 - view on LGTM.com

fixed alerts:

  • 10 for Implicit narrowing conversion in compound assignment
  • 8 for Dereferenced variable may be null
  • 3 for Potential input resource leak
  • 2 for Useless comparison test
  • 2 for Boxed variable is never null
  • 1 for Contradictory type checks

@Windchild292 Windchild292 changed the title (DRAFT) LGTM: Fixing all open issues LGTM: Fixing the vast majority of open issues Mar 1, 2022
@Windchild292
Copy link
Member Author

I'm considering this no longer a draft given it fixes 26 of the 30 issues, and will open a PR shortly after this is merged to handle the final four issues.

Copy link
Member

@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@Windchild292 Windchild292 merged commit 96d3be3 into MegaMek:master Mar 1, 2022
@Windchild292 Windchild292 deleted the dev_Windchild_LGTMFixes branch March 1, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants