Aerospace record sheet facelift, part 1 #413

neoancient · 2020-02-01T17:01:02Z

Spiffification of record sheets for aerospace and conventional fighters, fixed wing support vehicles (which use conventional fighter sheets), and small craft. Dropships and other large craft are deferred to a separate update.

A preview of some of the changes:

The aerospace armor diagrams have more background detail than mechs and vehicles, so I increased the width of the pip stroke and added a white fill.
I moved the heat sink pip drawing method from PrintMech to PrintEntity where it can be shared with aerospace fighters and small craft.
I moved the transport bay formatting code from PrintCapitalShip to InventoryWriter, where it can be shared by small craft.
I added a new utility method to PrintRecordSheet that creates a rounded rectangle, which is used for the external stores section.
I moved support vehicle basic and advanced fire control from the equipment table to the features section, which is in keeping with how it is shown in TROs.
I fixed a bug in the armor and structure pip layout code that can cause an endless loop when with an odd number of pips in a section that is divided in half horizontally, such as the conventional fighter nose section (which flanks the cockpit).

Here's the sample:
aerospace sample.pdf

It can happen when trying to maintain horizontal symmetry when all the rows have a gap in them and there are an odd number of pips.

…etter layout.

To increase visibility on armor diagrams with a lot of detail.

The presence and number of hardpoints is indicated by the number of boxes in the external stores section.

The number of boxes on the last row was calculated using % 5, which resulted in a full row not being shown.

# Conflicts: # data/images/recordsheets/fighter_aerospace_default.svg # src/megameklab/com/printing/PrintAero.java # src/megameklab/com/printing/PrintEntity.java

It can happen when trying to maintain horizontal symmetry when all the rows have a gap in them and there are an odd number of pips.

…etter layout.

To increase visibility on armor diagrams with a lot of detail.

The presence and number of hardpoints is indicated by the number of boxes in the external stores section.

The number of boxes on the last row was calculated using % 5, which resulted in a full row not being shown.

…AV value.

# Conflicts: # src/megameklab/com/util/UnitPrintManager.java

Indicate rear wing weapons by appending (R) to the name.

sixlettervariables

Just some tiny stuff, looks good.

(Have I mentioned how awesome the Rich Diffs are?)

src/megameklab/com/printing/PrintAero.java

NickAragua

Don't really have any change suggestions, just a couple of questions.

src/megameklab/com/printing/InventoryWriter.java

src/megameklab/com/printing/PrintMech.java

neoancient added 21 commits January 21, 2020 11:12

Start of aerospace record sheet printing.

26a2ee2

Equipment inventory and fluff image

e415d61

Start of aerospace record sheet printing.

f7de706

Equipment inventory and fluff image

73034ca

Conventional fighter/fixed wing support record sheet template.

c4056a1

Show transporters and SV chassis mods on aero sheets.

c90a964

Add fuel points to inventory section.

03f5324

Show only as many external stores boxes as the unit can use.

adadc00

Fixed possible endless loop in armor pip layout.

8378aae

It can happen when trying to maintain horizontal symmetry when all the rows have a gap in them and there are an odd number of pips.

Removed far forward armor pip rows in conventional fighter to get a b…

cdb4784

…etter layout.

Fixed id constant for role label to match what's used in the templates.

55a42a0

Aerodyne small craft record sheet.

271d464

Show cargo block on small craft

c1a7855

Thicken the armor/structure pip line a little.

3c43054

To increase visibility on armor diagrams with a lot of detail.

Spheroid small craft record sheet.

d6a8b9b

Increased size of critical hit boxes.

fdcdddf

Don't show fixed wing SV external stores hardpoint in inventory.

b587da5

The presence and number of hardpoints is indicated by the number of boxes in the external stores section.

Disable debugging code.

95896a4

Move SV basic/advanced fire control from equipment table to features.

99ed6e0

Fix logic error in printing external stores boxes.

9c5371d

The number of boxes on the last row was calculated using % 5, which resulted in a full row not being shown.

Merge remote-tracking branch 'origin/aero_rs' into aero_rs

8bfb489

# Conflicts: # data/images/recordsheets/fighter_aerospace_default.svg # src/megameklab/com/printing/PrintAero.java # src/megameklab/com/printing/PrintEntity.java

neoancient requested review from sixlettervariables and NickAragua February 1, 2020 17:01

neoancient added 7 commits February 3, 2020 12:06

Start of aerospace record sheet printing.

c4c8e7a

Equipment inventory and fluff image

257b279

Conventional fighter/fixed wing support record sheet template.

1fb9f93

Show transporters and SV chassis mods on aero sheets.

49aafaf

Add fuel points to inventory section.

b4db1c6

Show only as many external stores boxes as the unit can use.

f7bf82a

Fixed possible endless loop in armor pip layout.

057a9bc

It can happen when trying to maintain horizontal symmetry when all the rows have a gap in them and there are an odd number of pips.

neoancient added 15 commits February 3, 2020 12:09

Removed far forward armor pip rows in conventional fighter to get a b…

218e31a

…etter layout.

Fixed id constant for role label to match what's used in the templates.

27a4e37

Aerodyne small craft record sheet.

62d4072

Show cargo block on small craft

df7a087

Thicken the armor/structure pip line a little.

9ac0f6a

To increase visibility on armor diagrams with a lot of detail.

Spheroid small craft record sheet.

3c54c1c

Increased size of critical hit boxes.

990e865

Don't show fixed wing SV external stores hardpoint in inventory.

241b20b

The presence and number of hardpoints is indicated by the number of boxes in the external stores section.

Disable debugging code.

fbb0089

Move SV basic/advanced fire control from equipment table to features.

77c704a

Fix logic error in printing external stores boxes.

86d5431

The number of boxes on the last row was calculated using % 5, which resulted in a full row not being shown.

Consider both capital and standard av when deciding whether to print …

66a7b03

…AV value.

Remove unused aero printing classes.

6a5f4e0

Merge remote-tracking branch 'origin/aero_rs' into aero_rs

5144506

# Conflicts: # src/megameklab/com/util/UnitPrintManager.java

Use LWG/RWG for aerodyne small craft instead of LS/RS.

2f729b3

Indicate rear wing weapons by appending (R) to the name.

neoancient mentioned this pull request Feb 7, 2020

Aerospace record sheet facelift, part 2 #423

Closed

sixlettervariables approved these changes Feb 22, 2020

View reviewed changes

src/megameklab/com/printing/PrintAero.java Outdated Show resolved Hide resolved

src/megameklab/com/printing/PrintAero.java Outdated Show resolved Hide resolved

NickAragua approved these changes Feb 22, 2020

View reviewed changes

src/megameklab/com/printing/InventoryWriter.java Show resolved Hide resolved

src/megameklab/com/printing/PrintMech.java Show resolved Hide resolved

Header and spelling fix

92d2b6c

sixlettervariables approved these changes Feb 23, 2020

View reviewed changes

neoancient merged commit 08542e6 into master Feb 23, 2020

neoancient deleted the aero_rs branch February 23, 2020 02:37

neoancient mentioned this pull request Feb 23, 2020

Large craft rs #491

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aerospace record sheet facelift, part 1 #413

Aerospace record sheet facelift, part 1 #413

neoancient commented Feb 1, 2020

sixlettervariables left a comment

NickAragua left a comment

Aerospace record sheet facelift, part 1 #413

Aerospace record sheet facelift, part 1 #413

Conversation

neoancient commented Feb 1, 2020

sixlettervariables left a comment

Choose a reason for hiding this comment

NickAragua left a comment

Choose a reason for hiding this comment