Apply primitive armor multiplier to SC/DS free armor from SI #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoancient
requested review from
NickAragua,
sixlettervariables and
Windchild292
|
Build scan available at https://gradle.com/s/dc2dnd6qphl72 |
|
Build scan available at https://gradle.com/s/sdqc5c5lke6nk |
sixlettervariables
approved these changes
Oct 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See MegaMek/megamek#2299. This corrects the method used by the armor allocation view to display total armor points available and points remaining to be allocated. In researching this I discovered in the IO errata that the points from armor tonnage and SI should be combined before applying the primitive multiplier, rather than separately and rounded before combining, so there's a more general correction here that affects primitive jumpships as well. The fractional amount is retained here and the rounding is applied after the values have been added.
Fixes #752