Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign Ops Unit Rating -- Heavy Vee Bays Affecting Display of Light Vee Bays #228

Closed
dericpage opened this issue Nov 3, 2016 · 4 comments
Assignees
Labels

Comments

@dericpage
Copy link
Collaborator

If a unit has no dropships but does have heavy vehicles, it can cause the display of the light vehicle bays to show as negative. In general, the unit rating report needs to better indicate how heavy vee bays can be used for storing light vees while still displaying the actual number of light vee bays.

@Dylan-M
Copy link
Contributor

Dylan-M commented Nov 3, 2016

@dericpage Look at how I handled it for the Overview tab. I think that works correctly.

@dericpage
Copy link
Collaborator Author

dericpage commented Nov 3, 2016

Yeah, I see how that works pretty clear. Unfortunately, it doesn't fit the format I've got going with the unit ratings (though a consistency argument can be made for changing that). What I'm thinking of going with is something like:
`Transportation: 10

Mech Bays:                   0 needed /  12 available

Fighter Bays:                0 needed /   0 available

Small Craft Bays:            0 needed /   0 available

Protomech Bays:              0 needed /   0 available

Heavy Vehicle Bays:          4 needed /  12 available

Light Vehicle Bays:          4 needed /   8 available (0 light + 8 excess heavy)

BA Bays:                     0 needed /   0 available

Infantry Bays:               0 needed /   3 available

Docking Collars:             1 needed /   0 available

Has Jumpships?              No

Has Warships?               No`

@Dylan-M
Copy link
Contributor

Dylan-M commented Nov 3, 2016

I'm good with that, also feel free to adjust Overview to match if you want heh

dericpage added a commit that referenced this issue Nov 3, 2016
dericpage added a commit that referenced this issue Nov 4, 2016
dericpage added a commit that referenced this issue Nov 4, 2016
Issue #228: Campaign Ops Unit Rating -- Heavy Vee Bays Affecting Disp…
@dericpage
Copy link
Collaborator Author

Changes merged. This should be fixed with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants