Save/Load Game Does Not Properly Track Weight EquipmentParts

[mkerensky]

Environment

What version of MekHQ does your issue apply to? 0.43.9 RC3
What operating system are you using? Windows
Java 8 x64

Description

Weight of replacement hatchet parts is not saved correctly, resulting in stocked parts being invalid for future repairs. I think this is also true for other variable weight equipment, such as turrets and targeting computers, but I haven't done extensive troubleshooting on these.

This issue is rather annoying, but it can be worked around with GM mode features.
G3ck0 4rmyA.zip

Steps to reproduce:
Open attached campaign
Go to repair bay, look at NGS-4S Nightsky #2, which has a damaged hatchet needing replacement
Note that MHQ states 'no replacements on hand or on order'
Advance day, 1 new hatchet arrives but part is not considered valid for the repair
Check warehouse. New hatchet is 0.0 tons.
Go back to repair bay, use 'parts in use' button to order a replacement hatchet (reload and try again if order is unsuccessful)
Note that new order has a weight of 4.0 tons, and repair bay shows correct replacement part 'in transit'
If you save and load again, this new replacement will be set to 0.0 tons and will be invalid for the repair.

Files

customunits.zip

[Dylan-M]

TCs should be fine, I've frequently had them w/out issues in the warehouse.

[mkerensky]

Are we trying to fix this for stable then?

[jayof9s]

I've never had a TC in inventory retain it's weight actually. Mine may be from older versions but I'm pretty sure one of them was a relatively recent addition that reverted to 0 tons.

…

On Thu, Mar 22, 2018 at 10:41 AM, mkerensky ***@***.***> wrote: Are we trying to fix this for stable then? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#675 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANLi4OHGH7O59O7F6w5X692xDjVXWYGMks5tg7gWgaJpZM4S3Knb> .

[Dylan-M]

I wonder if mine only did it because they were reserved on a unit already (ongoing customization)?

And yes, this should be fixed for stable. Especially since it should be easy.

[jayof9s]

Might be if they were reserved for use. I had one in our Legacy campaign that is currently sitting at 0 tons but I don't know when that was added, so it could be old. I thought I tried to replace it with a correct one more recently and it returned to 0 but can't recall for sure. And 'recent' is probably a relative term.

…

On Thu, Mar 22, 2018 at 11:01 AM, Dylan Myers ***@***.***> wrote: I wonder if mine only did it because they were reserved on a unit already (ongoing customization)? And yes, this should be fixed for stable. Especially since it should be easy. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#675 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANLi4KIWuflOpwj4OQ0wlmE2ZzydcW-Iks5tg7zegaJpZM4S3Knb> .

[Dylan-M]

Forgot to close this issue once the branch that fixes it was merged in, whups. Closing now.