Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space Stations show in the hangar as unit type Jumpship #2

Closed
pheonixstorm opened this issue Jan 21, 2016 · 3 comments
Closed

Space Stations show in the hangar as unit type Jumpship #2

pheonixstorm opened this issue Jan 21, 2016 · 3 comments
Labels
Bug
Milestone
Stable 0.44

Comments

@pheonixstorm
Copy link
Collaborator

0.3.23

When viewing units in the hangar (All Units) the type column shows as Jumpship rather than Space Station.

When using the drop down menu space stations show up in the Jumpship unit type instead of the Space Station type.
@Dylan-M
Copy link
Contributor

Dylan-M commented Jan 24, 2016

Yes, Space Stations aren't fully implemented.

@Dylan-M Dylan-M added the Bug label Feb 24, 2016
@Dylan-M Dylan-M modified the milestones: Post-Stable, Stable Feb 24, 2016
@crazys1 crazys1 mentioned this issue Sep 15, 2016
Closed
@Dylan-M Dylan-M mentioned this issue Nov 22, 2016
Closed
@pheonixstorm
Copy link
Collaborator Author

The issue for this bug is in MM, specifically when determineUnitTypeCode is called in getTypeDisplayableName There is no check for the Space Station entity. If I am correct it should finally fix this issue so it can be closed.

@pheonixstorm
Copy link
Collaborator Author

This issue is now fixed with commit MegaMek/megamek@b5e30d9

@trent1098s trent1098s mentioned this issue Mar 14, 2017
Closed
@NickAragua NickAragua mentioned this issue Aug 29, 2017
Merged
neoancient pushed a commit that referenced this issue Oct 21, 2017
@mkerensky
Merge pull request #2 from MegaMek/mkerensky-REMF_Edge
ce8f1c2 
spa names
@bczretribution bczretribution mentioned this issue Dec 29, 2017
Closed
@mkerensky mkerensky mentioned this issue Mar 22, 2018
Closed
@NickAragua NickAragua mentioned this issue Jun 14, 2018
Merged
@sixlettervariables sixlettervariables mentioned this issue Aug 5, 2018
Closed
@bandildo bandildo mentioned this issue Aug 6, 2018
Closed
@BriannaTheBrave BriannaTheBrave mentioned this issue Oct 8, 2018
Open
@molemanBT molemanBT mentioned this issue Jun 18, 2020
Closed
Windchild292 pushed a commit that referenced this issue Aug 8, 2020
@binaryspica
Merge pull request #2 from MegaMek/master
78b7126 
Update_
@kipstafoo kipstafoo mentioned this issue Aug 21, 2020
Open
NickAragua added a commit to NickAragua/mekhq that referenced this issue Oct 14, 2020
@NickAragua
pre-merge commit MegaMek#2
525709d
@BullseyeSmith BullseyeSmith mentioned this issue Feb 26, 2021
Open
@zechrogers zechrogers mentioned this issue Apr 8, 2021
Open
NickAragua added a commit that referenced this issue May 15, 2021
@NickAragua
Merge pull request #2611 from NickAragua/scenario_data_fixes
ec11b7c 
Stratcon fix batch #2
Closed
NickAragua added a commit to NickAragua/mekhq that referenced this issue Jun 9, 2021
@NickAragua
whoops MegaMek#2
a291dd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
Stable 0.44
Development

No branches or pull requests
2 participants
@Dylan-M @pheonixstorm