Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AtB - StratCon implementation #2144

Merged
merged 176 commits into from Apr 21, 2021
Merged

Conversation

NickAragua
Copy link
Member

@NickAragua NickAragua commented Oct 16, 2020

Alpha-level version of StratCon. Expect bugs, bugs, bugs, inconsistencies, missed stuff, weird behavior, bugs.

Basically, this implements a new way of running AtB contracts. Upon arrival on the contract planet, check the new StratCon tab:

https://imgur.com/QsiZtCq

Here, depending on the type of contract, you'll be able to manage force deployments to generated scenarios across multiple tracks/theatres. A bunch of major features are unimplemented. A basic outline of how to play is in the attached text file.

The scenarios are generated more or less according to the rules here:

https://www.dropbox.com/s/lckqkdtgk4yemjm/AtB-Scenario-Stratcon.html?dl=0

HowToPlay10152020.txt

At this point, I need help playtesting, suggestions for mechanical/balance adjustments, things I missed in the UI, etc. Some features that I haven't gotten to yet are listed in the attached text file.

Don't bother too much with code review yet, as a lot of this is subject to change, unless it's substantive revisions.

  • bug that results in unresolved scenarios which have had forces committed not saving assigned forces
  • player usage of reinforcement lances in stratcon UI needs to have consequences if no support points available
  • implement penalties for ignored scenarios - loss of VPs
  • implement variable number of scenario modifiers
  • investigate why scenario modifiers are not being applied in some cases, and doubled up in some cases
  • tighten up objective detection/resolution as possible
  • finish tokenization
  • add configuration option to enable/disable this rule set
  • debug randomly generated hostile facility a) not rendering its type and b) not remaining on the board afterward

MekHQ/src/mekhq/campaign/Campaign.java Outdated Show resolved Hide resolved
MekHQ/src/mekhq/campaign/Campaign.java Outdated Show resolved Hide resolved
MekHQ/src/mekhq/campaign/stratcon/StratconScenario.java Outdated Show resolved Hide resolved
MekHQ/src/mekhq/gui/CampaignGUI.java Outdated Show resolved Hide resolved
MekHQ/docs/AtB Stuff/stratcon-faq.txt Outdated Show resolved Hide resolved
MekHQ/docs/AtB Stuff/stratcon-faq.txt Outdated Show resolved Hide resolved
Copy link
Member

@Windchild292 Windchild292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back up to having all but the StratCon Rules Manager reviewed, will be aiming to handle that one tonight

for (StratconScenario scenario : generatedScenarios) {
AtBDynamicScenarioFactory.finalizeScenario(scenario.getBackingScenario(), contract, campaign);

if(!autoAssignLances && !scenario.ignoreForceAutoAssignment()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(!autoAssignLances && !scenario.ignoreForceAutoAssignment()) {
if (!autoAssignLances && !scenario.ignoreForceAutoAssignment()) {

Copy link
Member

@Windchild292 Windchild292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the final file is reviewed. Just under forty comments until this is ready

NickAragua and others added 4 commits April 16, 2021 23:10
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
@MegaMek MegaMek deleted a comment from lgtm-com bot Apr 19, 2021
@MegaMek MegaMek deleted a comment from lgtm-com bot Apr 19, 2021
Copy link
Member

@Windchild292 Windchild292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AtB Enhancement Requests for Enhancement StratCon Bugs relating strictly to StratCon Alpha.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants