Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds focus events for all inputs #1252

Merged
merged 10 commits into from Sep 3, 2020
Merged

Conversation

Kronos11
Copy link
Contributor

@Kronos11 Kronos11 commented Aug 13, 2020

Simply adds in the

  • @onfocus
  • @onfocusin
  • @onfocusout

events to TextEdit

Fixes #1243

@Kronos11
Copy link
Contributor Author

@stsrki Is this the right approach? It's working on my own branch so just wanted to verify this is the approach you are thinking?

#endregion
}
}
#region Using directives
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to figure why entire TextEdit.razor.cs file is marked as changed. You only added three properties...

Copy link
Contributor Author

@Kronos11 Kronos11 Aug 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm developing in vscode on a mac, maybe thats it? Whitespace differences?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried formatting it. Nothing changes. Maybe it switched to different file encoding?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I look at it in vscode it just says that I only added those 3 properties, I don't see any whitespace differences.
Encoding is UTF-8 with BOM

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same for me, I just checked. UTF-8 with BOM.

@stsrki
Copy link
Collaborator

stsrki commented Aug 18, 2020

@Kronos11 Yeah, the PR look good. That's what I was thinking to do. At least until the major rewrite somewhere in the future :)

@Kronos11
Copy link
Contributor Author

Kronos11 commented Sep 1, 2020

Anything else required here? I can also work on adding it to some other components

@stsrki
Copy link
Collaborator

stsrki commented Sep 1, 2020

@Kronos11 The PR looks good. I need to run it and merge but always something else distract me. If you want to add new things I can wait with merge.

@Kronos11
Copy link
Contributor Author

Kronos11 commented Sep 1, 2020

I can add them to all razor components with an input box if that's ok with you?
Add the parameters to BaseInputComponent?

@stsrki stsrki merged commit 13b11fc into Megabit:dev092 Sep 3, 2020
@stsrki
Copy link
Collaborator

stsrki commented Sep 3, 2020

Good job in PR. Thank you!

@stsrki stsrki mentioned this pull request Sep 3, 2020
84 tasks
@stsrki stsrki changed the title Adds in focus events for TextEdit Adds focus events for all inputs Sep 3, 2020
@stsrki stsrki linked an issue Sep 3, 2020 that may be closed by this pull request
@Kronos11 Kronos11 deleted the 0.92-focus-events branch September 3, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle OnFocus Events on Inputs
2 participants