-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds focus events for all inputs #1252
Conversation
@stsrki Is this the right approach? It's working on my own branch so just wanted to verify this is the approach you are thinking? |
#endregion | ||
} | ||
} | ||
#region Using directives |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to figure why entire TextEdit.razor.cs
file is marked as changed. You only added three properties...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm developing in vscode on a mac, maybe thats it? Whitespace differences?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried formatting it. Nothing changes. Maybe it switched to different file encoding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when I look at it in vscode it just says that I only added those 3 properties, I don't see any whitespace differences.
Encoding is UTF-8 with BOM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same for me, I just checked. UTF-8 with BOM.
@Kronos11 Yeah, the PR look good. That's what I was thinking to do. At least until the major rewrite somewhere in the future :) |
Anything else required here? I can also work on adding it to some other components |
@Kronos11 The PR looks good. I need to run it and merge but always something else distract me. If you want to add new things I can wait with merge. |
I can add them to all razor components with an input box if that's ok with you? |
…rise into 0.92-focus-events
Good job in PR. Thank you! |
Simply adds in the
@onfocus
@onfocusin
@onfocusout
events to TextEdit
Fixes #1243