Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if component is rendered before calling JSRunner in Dispose() #928

Merged
merged 3 commits into from
May 30, 2020
Merged

Check if component is rendered before calling JSRunner in Dispose() #928

merged 3 commits into from
May 30, 2020

Conversation

Xeevis
Copy link
Contributor

@Xeevis Xeevis commented May 25, 2020

Fixes #923

@stsrki
Copy link
Collaborator

stsrki commented May 25, 2020

By the look of it, it seems good. I'm in the middle of some larger task so I will test it when I finish. Thank you for the contribution!

@Xeevis
Copy link
Contributor Author

Xeevis commented May 26, 2020

Sure, no problem. This code works for me well so far and I've made it based on this piece of documentation: Detect when the app is prerendering

@stsrki stsrki mentioned this pull request May 30, 2020
Closed
49 tasks
@stsrki
Copy link
Collaborator

stsrki commented May 30, 2020

I have tested it and everything works just fine. Also I have renamed IsRendered to Rendered.

Thank you once again!

@stsrki stsrki merged commit a33603e into Megabit:dev091 May 30, 2020
@Xeevis Xeevis deleted the dev091-prerendering branch June 1, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xeevis @stsrki