Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: input catalog is not respected #11

Closed
pnadolny13 opened this issue Apr 12, 2023 · 1 comment · Fixed by #22
Closed

bug: input catalog is not respected #11

pnadolny13 opened this issue Apr 12, 2023 · 1 comment · Fixed by #22

Comments

@pnadolny13
Copy link
Contributor

From slack https://meltano.slack.com/archives/C04TSH483DF/p1681325283410999

As far as I know, the way this is set up, it will not respect a passed in catalog fwiw (edited)
It may be unexpected if a user "discovers" a catalog, mutates it via meltano extras on-the-fly or directly, and it is not respected. Changes might include dropping a stream or changing a data type incorrectly inferred by genson.
@pnadolny13
Copy link
Contributor Author

It makes sense that this would be the case since its always doing an infer of the schema. It should only infer during discover, then during a sync it should use the catalog.

This was referenced Apr 24, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use input catalog MeltanoLabs/tap-dynamodb
1 participant
@pnadolny13