Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use repo_id instead of [repo, org] as partition key and index when possible #122

Open
ericboucher opened this issue May 17, 2022 · 3 comments

Comments

@ericboucher
Copy link
Contributor

Thanks to the changes introduced by #112, we now have a more reliable column to use for children streams.

Note, this is potentially a breaking changes and might change the DB index structure.

@ericboucher
Copy link
Contributor Author

Similarly, use user_id instead os username whenever possible

@ericboucher
Copy link
Contributor Author

ericboucher commented May 19, 2022

It could be interesting to link this to #95 (Consider running tap output into a target in CI) and catch when we introduce breaking changes by changing partition keys, primary keys and such

@aaronsteers
Copy link
Contributor

aaronsteers commented May 19, 2022

@ericboucher - Can we bump the major version when this comes through? I imagine many (most?) usages will break with the new primary key.

Since this is still a (relatively) new tap, I think now is a good time to make the change. I don't know how many dependencies exist on this repo but I think not a ton as of yet. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants