Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEM-118] Upvote/downvote comments by tapping arrows #423

Closed
Amcro opened this issue Jul 6, 2023 · 9 comments · Fixed by #473
Closed

[MEM-118] Upvote/downvote comments by tapping arrows #423

Amcro opened this issue Jul 6, 2023 · 9 comments · Fixed by #473
Assignees
Labels
enhancement request for enhancement to current app or features

Comments

@Amcro
Copy link

Amcro commented Jul 6, 2023

Is your feature request related to a problem? Please describe.

Only way to upvote/downvote comments is by swiping the comment. Adding option to click up/down arrow would open possibilities to remove swipe for voting and could be used to exit the post by swiping back anywhere on screen

Describe the solution you'd like

Arrows that currently display how many upvotes/downvotes each comment has could be used to vote that comment

MEM-118

@Amcro Amcro added the enhancement request for enhancement to current app or features label Jul 6, 2023
@Amcro
Copy link
Author

Amcro commented Jul 6, 2023

Oh, sorry for the confusion, i was talking about voting on comments

IMG_1087

If those can be interactive we could use comment swipes for something else

@ebits21
Copy link

ebits21 commented Jul 6, 2023

Edit: sorry, deleted my last comment.

I would also like the upvote count (544 in the pic) to be clickable for posts and let you upvote from there.

image

I think both the arrows on the right and the one on the left were clickable in Apollo and it worked well.

I hold my phone with my left hand. Allows for fast scrolling and upvoting.

@sgriff96
Copy link
Collaborator

sgriff96 commented Jul 7, 2023

Going to play around with some other options for voting. Not gonna commit to this exact behavior because I don't necessarily agree with it from a UX perspective, but we're looking into options.

@sgriff96 sgriff96 added the linear label Jul 7, 2023
@sgriff96 sgriff96 self-assigned this Jul 7, 2023
@sgriff96 sgriff96 changed the title Upvote/downvote comments by tapping arrows [MEM-118] Upvote/downvote comments by tapping arrows Jul 7, 2023
@kobra4711
Copy link

Just came here to request this same feature. I've had to help so many new Memmy users figure out that you have to swipe instead of tap, that I thought it was worth mentioning.

FWIW Apollo allowed swipes but also supported tap voting and tap collapsing of comments. And although I'm a layman user, I never had any UX issues with that app when voting and interacting with comments over the years.

@sgriff96
Copy link
Collaborator

sgriff96 commented Jul 8, 2023

Yea, fwiw I'm not a UX expert and def not a UX expert for ios design. I do a lot of web frontend work, and do know a decent amount about UX for websites. But I've been trying to pay attention to Apple guidelines, etc. and one thing you want is for any button to be easy enough to click with your thumb, tip of your finger, etc. And these just feel too small to conform to that standard lol

@sgriff96 sgriff96 linked a pull request Jul 8, 2023 that will close this issue
@sgriff96
Copy link
Collaborator

sgriff96 commented Jul 8, 2023

Fixed in #473, I've added them to the bottom of comments, with the option to disable this in Settings -> Content

simulator_screenshot_BEDE9B54-E3BD-4EAD-A7E3-5E0D36E2B8BF

@sgriff96 sgriff96 closed this as completed Jul 8, 2023
@timespaced
Copy link

@sgriff96 while I appreciate the buttons to add to swiping gestures, I think what is needed is the ability to tap on the upvote/downvote count to cast a vote, as shown
here. - I hear your worry about them being too small, but Apollo had this feature and it wasn’t a problem (I suppose you could add a tiny amount of space between the upvote arrow and count, and the downvote arrow and count to make it easier to tap).

@Amcro
Copy link
Author

Amcro commented Jul 8, 2023

I agree with @timespaced, it worked for Apollo perfectly for years, there is no reason it shouldn’t work. I really do appreciate adding buttons to upvote it’s a step forward but i think it’s taking more space for no reason and it seems people prefer using count arrows for upvote.

https://lemmy.world/post/1201326

@ebits21
Copy link

ebits21 commented Jul 11, 2023

I also agree. It worked in Apollo very well. Never had any issues as a user. Not hard to click.

It also makes sense that arrows would allow an upvote. Arrows are a very action-oriented UI feature. It could be surprising to the user that there is no action when pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement request for enhancement to current app or features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants