Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MEM-110] Show link's domain in compact list view #431

Closed
phriedrich opened this issue Jul 6, 2023 · 5 comments · Fixed by #627
Closed

[MEM-110] Show link's domain in compact list view #431

phriedrich opened this issue Jul 6, 2023 · 5 comments · Fixed by #627
Labels
enhancement request for enhancement to current app or features high priority should be implemented or fixed soon security security related issue

Comments

@phriedrich
Copy link
Contributor

phriedrich commented Jul 6, 2023

Is your feature request related to a problem? Please describe.
In the feed/list link posts show a small preview and the link symbol, and this is fine. But you have to open the post to see the source of the link.

Describe the solution you'd like
Showing the link's domain in the list would make it easier to decide if it's worth opening the post.

Like lemmy shows it in the browser version:

Source image

Especially on news related pages with several posts about a trending topic, it would be useful to directly the links domain and being able to select a good source.

Maybe this could be an option, like the voting buttons for compact view.

From SyncLinear.com | MEM-110

@phriedrich phriedrich added the enhancement request for enhancement to current app or features label Jul 6, 2023
@sgriff96
Copy link
Collaborator

sgriff96 commented Jul 6, 2023

We could probably put it at the end of the title, I believe that's what Apollo did

@sgriff96 sgriff96 added the linear label Jul 6, 2023
@sgriff96 sgriff96 changed the title Show link's domain in compact list view [MEM-110] Show link's domain in compact list view Jul 6, 2023
@sgriff96 sgriff96 removed the linear label Jul 8, 2023
@eoddc5 eoddc5 added high priority should be implemented or fixed soon security security related issue labels Jul 11, 2023
@eoddc5
Copy link
Contributor

eoddc5 commented Jul 11, 2023

tagging as security since domain / url can help with anti-phishing stuff

@bohn002
Copy link
Contributor

bohn002 commented Jul 12, 2023

Played with some models, and went back and forth on slack....
Options:
image
image
image

but went with:
image
image

updated LinkHelper's getBaseUrl to allow for optional subdomain returns...

@phriedrich
Copy link
Contributor Author

Great work @bohn002

Personally, I like the first one the best.

@bohn002
Copy link
Contributor

bohn002 commented Jul 12, 2023

we decided to put it in the title for now since the author/stamp/instance is a bit crowded in compact view currently. For now :P

@sgriff96 sgriff96 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement request for enhancement to current app or features high priority should be implemented or fixed soon security security related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants