Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with behavior parity on post and comment menus #511

Closed
eoddc5 opened this issue Jul 8, 2023 · 1 comment · Fixed by #603
Closed

Issue with behavior parity on post and comment menus #511

eoddc5 opened this issue Jul 8, 2023 · 1 comment · Fixed by #603
Labels
bug Something isn't working or working properly duplicate This issue or pull request already exists high priority should be implemented or fixed soon

Comments

@eoddc5
Copy link
Contributor

eoddc5 commented Jul 8, 2023 •
edited

Describe the bug

In a post, if you click the … menu button, there’s no haptics

You can’t close the menu pop up by clicking outside the bounds. Only by hitting cancel

Closing the menu doesn’t produce haptics

At the same time, the comments … menu in a post WILL produce haptics on click. You can escape the menu by clicking on the sceen outside of it OR hitting the cancel button. And there’s a haptic feedback on close.

Would be great to reproduce the same behavior on the post menu that is there on the comments menu (comments menu actions are nicer ux)

The menu's are also different visually (with a space between actions and cancel on comments ... , but no space in post)

To Reproduce
Steps to reproduce the behavior:

  1. Open a post.
  2. Click … on the post itself
  3. Try again with the … next to a comment
@eoddc5 eoddc5 added the bug Something isn't working or working properly label Jul 8, 2023
@eoddc5 eoddc5 changed the title No parity behaviors on post and comment menus not Issue with behavior parity on post and comment menus Jul 8, 2023
@eoddc5 eoddc5 added the medium priority should be completed when there is time label Jul 11, 2023
@eoddc5 eoddc5 mentioned this issue Jul 11, 2023
Closed
flx-sta added a commit to flx-sta/memmy that referenced this issue Jul 11, 2023
@flx-sta
fix post menu view & cancel behaviour. fixes Memmy-App#577 and (maybe) …
45d8d92 
…Memmy-App#511
@flx-sta flx-sta mentioned this issue Jul 11, 2023
Merged
4 tasks
@eoddc5 eoddc5 added high priority should be implemented or fixed soon duplicate This issue or pull request already exists and removed medium priority should be completed when there is time labels Jul 11, 2023
@eoddc5
Copy link
Contributor Author

eoddc5 commented Jul 11, 2023

closing as work relates to #577

@eoddc5 eoddc5 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2023
gkasdorf pushed a commit that referenced this issue Jul 11, 2023
@flx-sta
fix post menu view & cancel behaviour. fixes #577 and #511 (#599)
46788e1
@gkasdorf gkasdorf reopened this Jul 11, 2023
@flx-sta flx-sta mentioned this issue Jul 11, 2023
Closed
flx-sta added a commit to flx-sta/memmy that referenced this issue Jul 11, 2023
@flx-sta
add missing haptics for post menu
6026042 
and unify code-base of comment menu & post menu by using a hook (Memmy-App#511)
@flx-sta flx-sta mentioned this issue Jul 11, 2023
Merged
5 tasks
gkasdorf added a commit that referenced this issue Jul 12, 2023
@flx-sta @gkasdorf
add missing haptics for post menu(#511 (#603)
f51c78b 
Co-authored-by: Gavin Kasdorf <127079571+gkasdorf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working or working properly duplicate This issue or pull request already exists high priority should be implemented or fixed soon
Projects
None yet
Milestone
No milestone
2 participants
@eoddc5 @gkasdorf