Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing haptics for post menu(#511 #603

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

flx-sta
Copy link
Contributor

@flx-sta flx-sta commented Jul 11, 2023

and unify code-base of comment menu & post menu by using a hook (fixes #511)

finishing touch of #599

  • In a post, if you click the … menu button, there’s no haptics
  • You can’t close the menu pop up by clicking outside the bounds. Only by hitting cancel
  • Closing the menu doesn’t produce haptics. At the same time, the comments … menu in a post WILL produce haptics on click.
  • You can escape the menu by clicking on the sceen outside of it OR hitting the cancel button. And there’s a haptic feedback on close. Would be great to reproduce the same behavior on the post menu that is there on the comments menu (comments menu actions are nicer ux)
  • The menu's are also different visually (with a space between actions and cancel on comments ... , but no space in post)

I did not test the haptics behaviour but it's just copy pasta so it should work as expected. I've asked in Discord for the okay

and unify code-base of comment menu & post menu by using a hook (Memmy-App#511)
Copy link
Collaborator

@gkasdorf gkasdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested on device too and it works. Thanks.

@gkasdorf gkasdorf merged commit f51c78b into Memmy-App:main Jul 12, 2023
2 checks passed
@flx-sta flx-sta deleted the bug/511-add_missing_haptics branch July 12, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with behavior parity on post and comment menus
2 participants