Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix post menu view & cancel behaviour. fixes #577 #599

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

flx-sta
Copy link
Contributor

@flx-sta flx-sta commented Jul 11, 2023

fixes #577

PR Creator Checklist

Ensure you've checked the following before submitting your PR:

  • You've discussed making your changes with a member of the dev team per contributing rules in the README
  • Your changes are free of any lint errors
  • Your changes are free of any typescript errors
  • You've tested your changes

Summary

You can now also use the 'clickAway' method to close the menu just like the comments menu

Screenshots

Screen.Recording.2023-07-11.at.21.19.13.mov

Test Plan

  1. Open the app
  2. Open a post of your choice
  3. click the 3 vertical dots at the top right (posts menu)
  4. click anywhere where there is no buttons
  5. menu should close

Copy link
Collaborator

@gkasdorf gkasdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, forgot to subtract from the length. Simple change so I'll just go ahead and merge this. Thanks!

@flx-sta flx-sta changed the title fix post menu view & cancel behaviour. fixes #577 and (maybe) #511 fix post menu view & cancel behaviour. fixes #577 and #511 Jul 11, 2023
@gkasdorf gkasdorf merged commit 46788e1 into Memmy-App:main Jul 11, 2023
1 check passed
@flx-sta flx-sta deleted the bug/577-post-options-button-fix branch July 11, 2023 20:17
@flx-sta flx-sta changed the title fix post menu view & cancel behaviour. fixes #577 and #511 fix post menu view & cancel behaviour. fixes #577 Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report Post Option Misbehaves
2 participants