Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't Visit Old Comment Chain From Profile in 5.3 #786

Closed
ebits21 opened this issue Jul 21, 2023 · 3 comments · Fixed by #887
Closed

Can't Visit Old Comment Chain From Profile in 5.3 #786

ebits21 opened this issue Jul 21, 2023 · 3 comments · Fixed by #887
Assignees
@gkasdorf
Labels
bug Something isn't working or working properly medium priority should be completed when there is time

Comments

@ebits21
Copy link

ebits21 commented Jul 21, 2023

Describe the bug
If tapping on comments from profile nothing happens in 5.3.

Expected that the post and comment chain will open after.

Screenshots
https://github.com/Memmy-App/memmy/assets/19845100/a0a56ddc-3cd0-44b3-92e7-5e9008111e17
@eoddc5 eoddc5 added bug Something isn't working or working properly medium priority should be completed when there is time labels Jul 21, 2023
@eoddc5
Copy link
Contributor

eoddc5 commented Jul 21, 2023

Confirmed

@ebits21
Copy link
Author

ebits21 commented Jul 21, 2023 •
edited

Maybe related.

Tapping a comment in inbox loads the post with all comments loaded, not just the expected comment chain.

trim.02ACE109-9EE4-4965-A33D-5B07D0D958B1.MOV

Weird.

@ebits21 ebits21 mentioned this issue Jul 22, 2023
Closed
1 task
@gkasdorf
Copy link
Collaborator

Fixing this here in a few.

@ebits21 ebits21 mentioned this issue Jul 28, 2023
Closed
1 task
@gkasdorf gkasdorf linked a pull request Jul 29, 2023 that will close this issue
fix: take user directly to comment when tapping a comment in profile #887
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkasdorf gkasdorf

Labels
bug Something isn't working or working properly medium priority should be completed when there is time
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: take user directly to comment when tapping a comment in profile Memmy-App/memmy
3 participants
@eoddc5 @ebits21 @gkasdorf