Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass args via ... to mvtnorm::pmvnorm() #315

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

jdblischak
Copy link
Collaborator

To aid our discussion this afternoon. If we want to enable passing parameters to mvtnorm::pmvnorm(), this PR fixes that behavior. If we decide to keep this functionality, it would be nice to add some tests of realistic use cases so that this can be caught in the future.

xref: #235 (comment)

Note that the call to pmvnorm_combo() in gs_bound() does pass the ...:

gsDesign2/R/utility_combo.R

Lines 481 to 486 in f4a9e8d

p <- pmvnorm_combo(lower_bound,
upper_bound,
group = analysis[k_ind],
mean = .theta[k_ind],
corr = corr[k_ind, k_ind], ...
)

What this PR does is add the ... to the 2 calls in gs_prob_combo()

@jdblischak jdblischak self-assigned this Jan 17, 2024
@jdblischak
Copy link
Collaborator Author

Note that the CI failures are due to a problem with installing the dependency {withr}

Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this approach. Looking forward to those new tests! ✨

@nanxstats nanxstats merged commit 4ade37c into Merck:main Jan 18, 2024
8 checks passed
@jdblischak jdblischak deleted the dots-to-pmvnorm branch January 18, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants