Pass args via ...
to mvtnorm::pmvnorm()
#315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To aid our discussion this afternoon. If we want to enable passing parameters to
mvtnorm::pmvnorm()
, this PR fixes that behavior. If we decide to keep this functionality, it would be nice to add some tests of realistic use cases so that this can be caught in the future.xref: #235 (comment)
Note that the call to
pmvnorm_combo()
ings_bound()
does pass the...
:gsDesign2/R/utility_combo.R
Lines 481 to 486 in f4a9e8d
What this PR does is add the
...
to the 2 calls ings_prob_combo()