Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define get_combo_power() as a separate internal function #318

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Define get_combo_power() as a separate internal function #318

merged 1 commit into from
Jan 18, 2024

Conversation

jdblischak
Copy link
Collaborator

Closes #235

xref: #312, #315, #317

@jdblischak jdblischak self-assigned this Jan 18, 2024
nanxstats
nanxstats approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I see any obvious issues, so let's merge this.

I like in the refined uniroot() call how you correctly placed ... first to be passed to pmvnorm() and then extendInt = "yes" as further arguments to uniroot(). 👍

@nanxstats nanxstats merged commit b583123 into Merck:main Jan 18, 2024
8 checks passed
@jdblischak jdblischak deleted the get-combo-power branch January 18, 2024 20:13
@jdblischak jdblischak mentioned this pull request Jan 18, 2024
Merged
LittleBeannie
LittleBeannie reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jdblischak, I completely understand that this PR has already been merged. However, I do have a very minor comment regarding the documentation that I wanted to bring to your attention.

R/gs_design_combo.R Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleBeannie LittleBeannie LittleBeannie left review comments

@nanxstats nanxstats nanxstats approved these changes

@elong0527 elong0527 Awaiting requested review from elong0527

Assignees

@jdblischak jdblischak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Location of functions for root solving [lower priority]
3 participants
@jdblischak @nanxstats @LittleBeannie