Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that args are passed via ... to mvtnorm::pmvnorm() #317

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

jdblischak
Copy link
Collaborator

I decided to use the argument seed. I confirmed that if I interrupt the chain of ... by deleting them from one of the intermediate function calls, then these tests fail.

xref: Followup to #315, motivation in #235 (comment)

@jdblischak jdblischak self-assigned this Jan 18, 2024
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! I like the simple solution. I didn't know this seed argument existed before.

Looking at the news file, it turns out seed was first added in mvtnorm 1.2-0 released on 2023-06-02.

@nanxstats nanxstats merged commit 8bd4cfc into Merck:main Jan 18, 2024
8 checks passed
@jdblischak jdblischak deleted the test-dots-to-pmvnorm branch January 18, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants