Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing issues with keywords doesn't work #466

Closed
mboes opened this issue Aug 12, 2019 · 3 comments
Closed

Closing issues with keywords doesn't work #466

mboes opened this issue Aug 12, 2019 · 3 comments

Comments

@mboes
Copy link

mboes commented Aug 12, 2019

GitHub supports closing issues using keywords in PR's and commits. This has stopped working for us since we started using Mergify. If Mergify merges the PR, then any issues mentioned using keywords in either the PR message or any commit message will not close as part of the merge.

Related: https://github.community/t5/GitHub-API-Development-and/Pull-requests-merged-through-the-API-are-not-auto-closing-issues/td-p/25700. This could be due to Mergify not requesting enough permissions.

@jd
Copy link
Member

jd commented Aug 12, 2019

This has been resolved a few months ago. Can you check that Mergify had the right to write to issues?
We updated the permission of the app a few weeks ago but if you did not accept the new permissions, it won't work.

@jd
Copy link
Member

jd commented Aug 12, 2019

See #410 for details.

@mboes
Copy link
Author

mboes commented Aug 12, 2019

Ah indeed. Just this morning an issue got merged in that autoclosed fine. The issues I was looking were from early June. Will let you know if this happens again, but closing for now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants