Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Grabify links before loading URL #85

Open
ToksikProto opened this issue Jul 19, 2024 · 3 comments
Open

Block Grabify links before loading URL #85

ToksikProto opened this issue Jul 19, 2024 · 3 comments

Comments

@ToksikProto
Copy link

Most, if not all, VRChat video players have this problem. Someone can throw a grabify link into a video player, have it redirect to a video, and noone knows that they've just been IP grabbed. I would recommend setting a link whitelist including Youtube and other popular video-sharing sites and blocking other links to prevent Grabify (or other IP logger) links from getting loaded on a victims device

@MerlinVR
Copy link
Owner

Thanks, I'll look into adding a domain disallow list. I can't really only have an allow list by default as it would break normal custom CDN use and whatnot which is fairly common for events. This sounds like something where VRC should consider blocking common low-hanging fruit IP grabbers, is there a canny for this?

@ToksikProto
Copy link
Author

Well with most IP grabber sites, they allow you to use custom URL's as well, and those are constantly being changed and updated, so there's no really effective way to block them. The way I'm doing it is a small addition to the ValidateUrl boolean, where I've added an "Else" statement below your Youtube link check that goes through a string array and check if the website is one of them, and if not it returns a "False"

@ToksikProto
Copy link
Author

I edited my quick fix into something more permanent on my end

image

I can make a pull-request if you'd like me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants