Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda caching does not seem to be working for macos-13 #454

Closed
bhaller opened this issue Jul 15, 2024 · 3 comments
Closed

conda caching does not seem to be working for macos-13 #454

bhaller opened this issue Jul 15, 2024 · 3 comments
Assignees

Comments

@bhaller
Copy link
Contributor

bhaller commented Jul 15, 2024

Hi @petrelharp. You can see that building on macos-13 is not working. GitHub recently deactivated/removed macos-11; it's time to get macos-13 working (which it never has). An example of the failure can be seen here:

https://github.com/MesserLab/SLiM/actions/runs/9931045744/job/27430479498

The problem is with conda; you can see the error:

/Users/runner/.profile: line 22: conda: command not found

(Just above that there is a "TODO", by you I think, that might also be relevant.) This error is mystifying to me, though, because earlier in the log are the steps for "Cache conda and dependencies" and "Install conda". The log says "Cache restored successfully", and it seems to think it succeeded. So why can't it find conda later on? And why does this problem only manifest on macos-13, not macos-12?

This kind of thing mystifies me. Since you put the conda caching stuff in, and perhaps understand it, can you please fix this problem? Thankyouthankyouthankyou.

@bhaller
Copy link
Contributor Author

bhaller commented Jul 15, 2024

Hey, for some reason I can assign issues to you now! Woot!

@bhaller
Copy link
Contributor Author

bhaller commented Jul 15, 2024

If it makes the design/maintenance of this conda stuff simpler, I wonder: is it really worth using this cache mechanism? A GitHub admin claimed, in a thread I was reading to try to orient myself on this problem, that installing conda takes ~20 seconds (miniconda, in particular, I guess; not sure whether that suffices for our purposes). That is not huge; maybe if the caching is giving us difficulties it isn't worth it? But I leave that up to you. :->

@bhaller
Copy link
Contributor Author

bhaller commented Jul 18, 2024

This got fixed by @currocam in #457, closing.

@bhaller bhaller closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants