Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of unrecognised "file_type" configuration #130

Closed
rhattersley opened this issue Sep 23, 2019 · 2 comments
Closed

Handling of unrecognised "file_type" configuration #130

rhattersley opened this issue Sep 23, 2019 · 2 comments
Labels

Comments

@rhattersley
Copy link
Member

Provide some sort of fail-fast feedback for invalid "file_type" values.

Currently if the configuration file contains an unsupported value for "file_type" then data.file_loader() silently returns an implicit None for the loader, resulting in a later error of:

  File ".../forest/forest/view.py", line 19, in render
    self.source.data = self.loader.image(state)
AttributeError: 'NoneType' object has no attribute 'image'

@andrewgryan
Copy link
Collaborator

Agreed, this is a glaring error that could be patched with a unit test checking for an Exception given a invalid file_type keyword

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 1, 2021
@github-actions github-actions bot closed this as completed Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants