Skip to content
This repository has been archived by the owner on May 12, 2022. It is now read-only.

Address Book for mobile #126

Open
bdresser opened this issue Jul 30, 2019 · 14 comments
Open

Address Book for mobile #126

bdresser opened this issue Jul 30, 2019 · 14 comments
Assignees
Labels
mobile Related to mobile app needs user testing

Comments

@bdresser
Copy link

allow users to save addresses for simpler & safer sending

can be modeled closely after the extension's designs - are there any key platform differences that require modifications for mobile?

dev issue on mobile board here: MetaMask/metamask-mobile#128

@bdresser bdresser added the mobile Related to mobile app label Jul 30, 2019
@bdresser
Copy link
Author

bdresser commented Aug 8, 2019

probably want some usability testing! @omnat

@omnat
Copy link
Collaborator

omnat commented Sep 17, 2019

Sprint 21:

  • CJ having call with Esteban and Bruno to transfer extension designs to mobile

@cjeria
Copy link
Contributor

cjeria commented Sep 18, 2019

Had a good call with the mobile devs today - notes below. I also did some prior send flow pattern research, looking at how other apps implement contact list in send flows you can see here.

Contact list In the send flow updates:

  • Keep the network in top bar, as implemented (no switching ability)
  • Display the to input/search bar below the top bar
  • Show the from account in for context
  • Add the ability to change the token (like a down arrow next to the currency symbol)
  • Make Amount input more predominant - for easier interaction on mobile

Did not discuss the contact list for settings, left for the next phase.

@omnat
Copy link
Collaborator

omnat commented Sep 18, 2019

One thing Rachel and I noticed today in the Send flow in extension.. perhaps good to re-consider for mobile too.

In the flow of 'Transfer between accounts', the chosen from account is also given as an option to select for to address. I believe there's no use-case when someone would want to send from Account 1 to Account 1, so we could help prevent an error here.

So, in the list of accounts, lets show all of user accounts except the from account. wdyt @cjeria ?

@cjeria
Copy link
Contributor

cjeria commented Sep 19, 2019

In the flow of 'Transfer between accounts', the chosen from account is also given as an option to select for to address. I believe there's no use-case when someone would want to send from Account 1 to Account 1, so we could help prevent an error here.

Yes, we touched on this during design hand-off for the extension and I think it's a good constraint to add. I'll make a call out in the designs about it. We may also want to do that for the extension cc @bdresser WDYT?

@omnat
Copy link
Collaborator

omnat commented Sep 30, 2019

In the flow of 'Transfer between accounts', the chosen from account is also given as an option to select for to address. I believe there's no use-case when someone would want to send from Account 1 to Account 1, so we could help prevent an error here.

Is this update of in dev backlog for extension? @bdresser
We doing this in mobile?

For mobile, next steps (week of Sept 30):

  • Add primary buttons to Send flow

  • We'll show network on Amount tx screen, and which account you are sending the tx from

  • Add token switcher within the send flow

A future thing to consider is a custom keyboard (issue created for this already in mobile dev backlog)

@benjaminaaron
Copy link

benjaminaaron commented Sep 30, 2019

I love the new Contacts feature in the extension! It would be super useful to be able to sync it with mobile 💻🔄📱Is that planned by any chance?

As a DApp developer I would love to be able to have a way to use the contacts throughout Browser-DApps as well. Not just for sending transactions but as parameters for calling smart contract functions. Something like long/right-press on a text field and among copy/paste etc. there is a new option "insert address from contacts" 📖
Or having a way to access MetaMask contacts via the web3 or unlocked window.ethereum object? So I could check if an inserted nickname has an entry in contacts 🔍 Maybe that is possible already?
(I posted the same on a extension issue)

@bdresser
Copy link
Author

bdresser commented Oct 1, 2019

filed here @omnat @cjeria MetaMask/metamask-extension#7237. i don't think this is super high priority, haven't heard any users having trouble with this, but should be simple to fix.

@benjaminaaron yes, we do plan on syncing contacts - eventually! hang tight. no plans yet to make contacts available via the ethereum provider, there's a lot of user privacy issues to think through there, but i can understand how that'd be convenient for dapps.

@omnat
Copy link
Collaborator

omnat commented Oct 28, 2019

Next steps in Sprint 23:

  • Updates to prototype (per Figma notes)
  • Milestone to hand-off to mobile for development

@cjeria
Copy link
Contributor

cjeria commented Nov 12, 2019

Notes from design review:

  • Updates to the design need to be made per notes in the figma file
  • Feedback from Dan - display the "from" address in the send flow. How many users are mistakingly sending from the wrong account?

@omnat
Copy link
Collaborator

omnat commented Nov 12, 2019

  • @rachelcope to align 'Send/Submit' per the error designs updates

@omnat
Copy link
Collaborator

omnat commented Nov 25, 2019

@cjeria to setup call with Esteban to transfer this

@cjeria
Copy link
Contributor

cjeria commented Dec 18, 2019

We reviewed the latest implementation during the mobile design QA call.

Address book in send flow:

  • @christian.jeria to work on copy for error messages in the to screen. To reference copy we used in the extension
  • Reconsider our current pattern press/hold to delete assets from asset list and contacts from inside settings - @estebanmino keep it press/hold. We'll internally test the build and see if interaction needs to be changed.
  • Global primary currency settings - default to primary currency throughout send flow - @estebanmino to make this logic consistent
  • in the Amount screen, if currency values are too long, they get chopped - @esteban.mino to look into using dynamically resize text here
  • @estebanmino mino caught a bug on hex when sending ETH - the hex not showing in the small pop up
  • Internally test after building @estebanmino Usability concern when swapping Fiat to USD in the Amount screen. The native currency selector shows the token (e.g. ETH), not USD. We may want to set up a quick usability test for this.

Approve screen

  • @cjeria to do design QA. After confirming an Approve call, we show a full-screen success confirmation and the toast. Let’s omit the full-screen success message and only show a toast message.

@cjeria
Copy link
Contributor

cjeria commented Jan 29, 2020

Design feedback provided in this doc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
mobile Related to mobile app needs user testing
Projects
None yet
Development

No branches or pull requests

6 participants