Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default approval controller type #321

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

rekmarks
Copy link
Member

Removes the default approval controller type, and requires an explicitly specified type for all approvals.

@rekmarks rekmarks requested a review from a team as a code owner December 17, 2020 08:08
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 8a914d1 into develop Jan 19, 2021
@rekmarks rekmarks deleted the approval-controller-remove-default-type branch January 19, 2021 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants