Update to TypeScript 4.1 #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TypeScript has been updated to v4.1 [1]. I'm not aware of any changes that impact our code, but the update did highlight a few new minor errors in our code for some reason. These have all been fixed. There was also a breaking change that affected us: `resolve` parameters for Promises are no longer optional. We're not required to use `Promise<void>` for any Promises not returning a value. [1]: https://devblogs.microsoft.com/typescript/announcing-typescript-4-1/
Gudahtt
force-pushed
the
update-typescript-4.1
branch
from
e8c4f91
to
042186c
Compare
brad-decker
approved these changes
Feb 26, 2021
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
TypeScript has been updated to v4.1 [1]. I'm not aware of any changes that impact our code, but the update did highlight a few new minor errors in our code for some reason. These have all been fixed. There was also a breaking change that affected us: `resolve` parameters for Promises are no longer optional. We're not required to use `Promise<void>` for any Promises not returning a value. [1]: https://devblogs.microsoft.com/typescript/announcing-typescript-4-1/
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
TypeScript has been updated to v4.1 [1]. I'm not aware of any changes that impact our code, but the update did highlight a few new minor errors in our code for some reason. These have all been fixed. There was also a breaking change that affected us: `resolve` parameters for Promises are no longer optional. We're not required to use `Promise<void>` for any Promises not returning a value. [1]: https://devblogs.microsoft.com/typescript/announcing-typescript-4-1/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript has been updated to v4.1. I'm not aware of any changes that impact our code, but the update did highlight a few new minor errors in our code for some reason. These have all been fixed. There was also a breaking change that affected us:
resolveparameters for Promises are no longer optional. We're not required to usePromise<void>for any Promises not returning a value.