Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom nonce #381

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Allow custom nonce #381

merged 2 commits into from
Mar 17, 2021

Conversation

rickycodes
Copy link
Contributor

@rickycodes rickycodes commented Mar 10, 2021

Allow the client to specify a nonce rather than using the network (but still falling back)

This is used in MetaMask/metamask-mobile#2371

@rickycodes rickycodes requested a review from a team as a code owner March 10, 2021 01:38
@rickycodes rickycodes force-pushed the feature/custom-nonce branch 2 times, most recently from 46aad52 to 67cd832 Compare March 12, 2021 03:45
Gudahtt
Gudahtt previously approved these changes Mar 16, 2021
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Though I just noticed a related pre-existing problem: nonce is missing from the TransactionMeta type. Nevermind, it's there, on the Transaction type.

@rickycodes rickycodes merged commit 10c9611 into develop Mar 17, 2021
@rickycodes rickycodes deleted the feature/custom-nonce branch March 17, 2021 19:37
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants