Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update OPTIMISM_TESTNET to OPTIMISM_SEPOLIA #4014

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Mar 5, 2024

Explanation

This PR replaces the reference to OP goerli to OP sepolia. It also renames the variable OPTIMISM_TESTNET to OPTIMISM_SEPOLIA.

Only made this change on the transaction controller.

Renaming the variable and switching to Sepolia is a breaking change, please use Sepolia and OPTIMISM_SEPOLIA instead of OPTIMISM_TESTNET.

References

Changelog

@metamask/transaction-controller

Removed

  • BREAKING: Renamed OPTIMISM_TESTNET to OPTIMISM_SEPOLIA and updated the chainId accordingly.
  • BREAKING: Updated the etherscan subdomain that was for OPTIMISM_TESTNET from goerli to sepolia.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@sahar-fehri sahar-fehri requested a review from a team as a code owner March 5, 2024 11:23
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MajorLift MajorLift mentioned this pull request Mar 19, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants