fix: update usage of OP goerli to OP Sepolia #8784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sahar-fehri
added
Run Smoke E2E
|
3 tasks
sahar-fehri
added
Run Smoke E2E
|
sahar-fehri
force-pushed
the
feat/replace-optimism-goerli-with-sepolia
branch
from
afb7de8
to
57fc85a
Compare
|
gauthierpetetin
added
the
needs-dev-review
sahar-fehri
added
Run Smoke E2E
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8784 +/- ##
=======================================
Coverage 41.61% 41.61%
=======================================
Files 1269 1269
Lines 30871 30871
Branches 3086 3086
=======================================
Hits 12846 12846
Misses 17248 17248
Partials 777 777 ☔ View full report in Codecov by Sentry. |
sahar-fehri
added a commit
to MetaMask/core
that referenced
this pull request
Mar 4, 2024
## Explanation This PR replaces the reference to OP goerli to OP sepolia. It also renames the variable `OPTIMISM_TESTNET` to `OPTIMISM_SEPOLIA`. Renaming the variable and switching to Sepolia is a breaking change, please use Sepolia and `OPTIMISM_SEPOLIA` instead of `OPTIMISM_TESTNET`. ## References * Fixes MetaMask/mobile-planning#1569 * Related to [#67890](MetaMask/metamask-mobile#8784) ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/transaction-controller` **Removed** - **BREAKING**: Renamed `OPTIMISM_TESTNET` to `OPTIMISM_SEPOLIA` and updated the chainId accordingly. - **BREAKING**: Updated the etherscan subdomain that was for OPTIMISM_TESTNET from goerli to sepolia. ### `@metamask/preferences-controller` **Removed** - **BREAKING**: Renamed `OPTIMISM_TESTNET` to `OPTIMISM_SEPOLIA` and updated the chainId accordingly. ### `@metamask/name-controller` **Removed** - **BREAKING**: Renamed `OPTIMISM_TESTNET` to `OPTIMISM_SEPOLIA` and updated the chainId accordingly. - **BREAKING**: updated the etherscan subdomain for OPTIMISM_TESTNET from goerli to sepolia ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
tommasini
requested changes
Mar 4, 2024
mcmire
pushed a commit
to MetaMask/core
that referenced
this pull request
Mar 4, 2024
## Explanation This PR replaces the reference to OP goerli to OP sepolia. It also renames the variable `OPTIMISM_TESTNET` to `OPTIMISM_SEPOLIA`. Renaming the variable and switching to Sepolia is a breaking change, please use Sepolia and `OPTIMISM_SEPOLIA` instead of `OPTIMISM_TESTNET`. ## References * Fixes MetaMask/mobile-planning#1569 * Related to [#67890](MetaMask/metamask-mobile#8784) ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/transaction-controller` **Removed** - **BREAKING**: Renamed `OPTIMISM_TESTNET` to `OPTIMISM_SEPOLIA` and updated the chainId accordingly. - **BREAKING**: Updated the etherscan subdomain that was for OPTIMISM_TESTNET from goerli to sepolia. ### `@metamask/preferences-controller` **Removed** - **BREAKING**: Renamed `OPTIMISM_TESTNET` to `OPTIMISM_SEPOLIA` and updated the chainId accordingly. ### `@metamask/name-controller` **Removed** - **BREAKING**: Renamed `OPTIMISM_TESTNET` to `OPTIMISM_SEPOLIA` and updated the chainId accordingly. - **BREAKING**: updated the etherscan subdomain for OPTIMISM_TESTNET from goerli to sepolia ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Hey @tommasini , were you asking about this PR MetaMask/core#3999 ? |
13 tasks
This was referenced Mar 5, 2024
matthewwalsh0
approved these changes
Mar 6, 2024
sahar-fehri
force-pushed
the
feat/replace-optimism-goerli-with-sepolia
branch
from
b513592
to
1da55aa
Compare
|
sahar-fehri
added a commit
to MetaMask/core
that referenced
this pull request
Mar 6, 2024
## Explanation This PR replaces the reference to OP goerli to OP sepolia. It also renames the variable `OPTIMISM_TESTNET` to `OPTIMISM_SEPOLIA`. Only made this change on the transaction controller. Renaming the variable and switching to Sepolia is a breaking change, please use Sepolia and `OPTIMISM_SEPOLIA` instead of `OPTIMISM_TESTNET`. ## References * Fixes MetaMask/mobile-planning#1569 * Related to [#67890](MetaMask/metamask-mobile#8784) ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/transaction-controller` **Removed** - **BREAKING**: Renamed `OPTIMISM_TESTNET` to `OPTIMISM_SEPOLIA` and updated the chainId accordingly. - **BREAKING**: Updated the etherscan subdomain that was for OPTIMISM_TESTNET from goerli to sepolia. ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
tommasini
approved these changes
Mar 6, 2024
sahar-fehri
added
Run Smoke E2E
|
sahar-fehri
added
Run Smoke E2E
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-7.19.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR's replaces the reference to OP goerli to OP sepolia.
Users that switch to OP goerli should still see the warning, and if they have already made transactions on OP goerli, they should still see them on activity tab.
Including the /compare diff URLs on core for visibility:
Core PR: MetaMask/core#3999
MetaMask/core@patch/mobile-transaction-controller-6-1-0...fix/update-OP-testnet-to-OP-sepolia
MetaMask/core@patch/mobile-transaction-controller-7-1-0...fix/update-OP-testnet
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/1569
CORE PR: MetaMask/core#3999
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-02-29.at.14.52.54.mov
After
Screen.Recording.2024-02-29.at.14.45.30.mov
Pre-merge author checklist
Pre-merge reviewer checklist