Starbase added #163
Merged
Starbase added #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
suggested changes
Sep 20, 2018
There was a problem hiding this comment.
Hi @TOMOAKI12345 please make sure tests are passing, in this case, the address is not checksum valid. Please let me know in order to merge.
estebanmino
added
the
pending checksum
|
thank you for pointing out, fixed and test passed. |
|
Hi @TOMOAKI12345 , ok it's perfect. I just noticed that the logo is 168 KB, could you change it for smaller one? Less than 50 KB would be ideal. Thanks. |
|
@estebanmino thank you for reply, yes compressed. now 31kb |
estebanmino
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starbase information added. We are using Metamask for our platform development, thank you, Metamask team!
https://starbase.co/