Skip to content

Commit

Permalink
fix: stopgap for BigNumber shift NaN issue (#24691)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Stopgap for #24690

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24691?quickstart=1)

## **Related issues**

Related: #24690
– do not close this.

## **Manual testing steps**

1. Try to reproduce
#24690

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
dbrans committed May 21, 2024
1 parent c586d33 commit 4233f9e
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,9 @@ function getTokenBalanceChanges(
};

const decimals =
asset.standard === TokenStandard.ERC20 && erc20Decimals[asset.address]
? erc20Decimals[asset.address]
// TODO(dbrans): stopgap for https://github.com/MetaMask/metamask-extension/issues/24690
asset.standard === TokenStandard.ERC20
? erc20Decimals[asset.address] ?? ERC20_DEFAULT_DECIMALS
: 0;
const amount = getAssetAmount(tokenBc, decimals);

Expand Down

0 comments on commit 4233f9e

Please sign in to comment.